From: Laurent Vivier <lvivier@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 05/24] crypto: Use O_CLOEXEC in qcrypto_random_init
Date: Tue, 7 May 2019 11:28:09 +0200 [thread overview]
Message-ID: <7775de94-70ee-5f70-2747-f81a6390d594@redhat.com> (raw)
In-Reply-To: <20190506173353.32206-6-richard.henderson@linaro.org>
On 06/05/2019 19:33, Richard Henderson wrote:
> Avoids leaking the /dev/urandom fd into any child processes.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> crypto/random-platform.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
next prev parent reply other threads:[~2019-05-07 9:30 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 17:33 [Qemu-devel] [PATCH v4 00/24] Add qemu_getrandom and ARMv8.5-RNG etc Richard Henderson
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 01/24] configure: Link test before auto-enabling gnutls Richard Henderson
2019-05-07 8:28 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 02/24] crypto: Merge crypto-obj-y into libqemuutil.a Richard Henderson
2019-05-07 9:03 ` Laurent Vivier
2019-05-08 3:58 ` Richard Henderson
2019-05-08 4:43 ` Richard Henderson
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 03/24] crypto: Reverse code blocks in random-platform.c Richard Henderson
2019-05-07 9:11 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 04/24] crypto: Do not fail for EINTR during qcrypto_random_bytes Richard Henderson
2019-05-07 9:19 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 05/24] crypto: Use O_CLOEXEC in qcrypto_random_init Richard Henderson
2019-05-07 9:28 ` Laurent Vivier [this message]
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 06/24] crypto: Use getrandom for qcrypto_random_bytes Richard Henderson
2019-05-07 9:45 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 07/24] crypto: Change the qcrypto_random_bytes buffer type to void* Richard Henderson
2019-05-07 10:09 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 08/24] ui/vnc: Split out authentication_failed Richard Henderson
2019-05-07 10:35 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 09/24] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc Richard Henderson
2019-05-07 10:49 ` Laurent Vivier
2019-05-08 0:32 ` Richard Henderson
2019-05-08 7:11 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 10/24] util: Add qemu_guest_getrandom and associated routines Richard Henderson
2019-05-07 12:19 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 11/24] cpus: Initialize pseudo-random seeds for all guest cpus Richard Henderson
2019-05-07 12:19 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 12/24] linux-user: " Richard Henderson
2019-05-07 14:06 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 13/24] linux-user: Call qcrypto_init if not using -seed Richard Henderson
2019-05-07 14:13 ` Laurent Vivier
2019-05-08 4:11 ` Richard Henderson
2019-05-08 7:10 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 14/24] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM Richard Henderson
2019-05-07 14:15 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 15/24] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys Richard Henderson
2019-05-07 14:40 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 16/24] linux-user: Remove srand call Richard Henderson
2019-05-07 14:41 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 17/24] aspeed/scu: Use qemu_guest_getrandom_nofail Richard Henderson
2019-05-07 14:43 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 18/24] hw/misc/nrf51_rng: " Richard Henderson
2019-05-07 14:45 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 19/24] hw/misc/bcm2835_rng: " Richard Henderson
2019-05-07 15:09 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 20/24] hw/misc/exynos4210_rng: Use qemu_guest_getrandom Richard Henderson
2019-05-07 15:10 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 21/24] target/arm: Put all PAC keys into a structure Richard Henderson
2019-05-07 15:23 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 22/24] target/arm: Implement ARMv8.5-RNG Richard Henderson
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 23/24] target/ppc: Use qemu_guest_getrandom for DARN Richard Henderson
2019-05-07 15:36 ` Laurent Vivier
2019-05-06 17:33 ` [Qemu-devel] [PATCH v4 24/24] target/i386: Implement CPUID_EXT_RDRAND Richard Henderson
2019-05-06 21:03 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7775de94-70ee-5f70-2747-f81a6390d594@redhat.com \
--to=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).