From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Eduardo Habkost <eduardo@habkost.net>,
Richard Henderson <richard.henderson@linaro.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] hw/i386: Rename kvmvapic.c -> vapic.c
Date: Thu, 23 Nov 2023 12:28:36 +0100 [thread overview]
Message-ID: <77a23a59-1d36-4112-9716-6839a7d0df21@linaro.org> (raw)
In-Reply-To: <CABgObfbaAhOki7--tdMu-59Sv+k8aCDG0N-vrCGpbwwBj-f45A@mail.gmail.com>
On 23/11/23 11:14, Paolo Bonzini wrote:
>
>
> Il mar 5 set 2023, 16:52 Philippe Mathieu-Daudé <philmd@linaro.org
> <mailto:philmd@linaro.org>> ha scritto:
>
> vAPIC isn't KVM specific, so having its name prefixed 'kvm'
> is misleading. Rename it simply 'vapic'. Rename the single
> function prefixed 'kvm'.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org
> <mailto:philmd@linaro.org>>
> ---
> Interestingly there is a strong dependency on (Kconfig) APIC,
> but I couldn't get a single x86 machine building without the
> Kconfig 'APIC' key.
>
>
> In theory ISAPC could be built without APIC. But it isn't quite there.
Ah I see, I'll keep that in mind.
> You can go ahead and queue it, thanks!
Thanks!
prev parent reply other threads:[~2023-11-23 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 14:51 [PATCH] hw/i386: Rename kvmvapic.c -> vapic.c Philippe Mathieu-Daudé
2023-11-22 14:31 ` [PATCH-for-9.0] " Philippe Mathieu-Daudé
2023-11-23 10:14 ` [PATCH] " Paolo Bonzini
2023-11-23 11:28 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77a23a59-1d36-4112-9716-6839a7d0df21@linaro.org \
--to=philmd@linaro.org \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).