From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD4F7CFB44A for ; Mon, 7 Oct 2024 16:25:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxqXY-0003UZ-1P; Mon, 07 Oct 2024 12:24:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxqXH-0003Ow-S8 for qemu-devel@nongnu.org; Mon, 07 Oct 2024 12:24:40 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sxqXG-00077q-0B for qemu-devel@nongnu.org; Mon, 07 Oct 2024 12:24:39 -0400 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-20b01da232aso36374375ad.1 for ; Mon, 07 Oct 2024 09:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728318276; x=1728923076; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZhTNi0J0LZKB7af7Zb43WsGxxujabzbI10ATH65EwyQ=; b=PDAQ+7XDyNXWVQ+VjaqHW6+s331zBzvmUOgp+R5RBOORppork13kElRvdGDtOwpjnq u/JRiCYGHs2rxr7r6tdaGnSegE/1jeNv1AuWUHjqLCebQwcdl+ZCbTXNMhaVvMv4oIa6 rHwNxVpK1J3eVoiQAY3fidd3e8EpDG3ndzpWHDTQ02/N3+Orq1r/yXKCDPkEutennOom PDhDuCBCI4cSZkG3OW1GF6z0eWyJjqCQHLIPJ7djiZMIEftnilYLAfwmXzc/DJIOOmcs j6MxEfKRSvANqQ0w6wLIhNn8X5GZB+bdFRZIvDCnfIsSgsL6cnqwWY+N7Uz3Xcek2LQb xyag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728318276; x=1728923076; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZhTNi0J0LZKB7af7Zb43WsGxxujabzbI10ATH65EwyQ=; b=PxeMMC4ZOvOZZNU6hLx1+qhrxdza1+g959ZncRcs186UoDIJqrBZVh8D+xuxrKqgP4 B5lIqOPNBaEtbY6HOcE/V8tnMXKmuQR18p+bTSOB4p+49CW440aP/7I2bANUZftDeTq2 YKHnEd8Q9yWN8XwlFS9fAHlYngC3fUmwAi3HzIAJ8velfbI4MGKiNbEULKL6+SCnr8ov f8ob3KY7NTV4U98XSK7C604TFoGYyzHYUOKj0Jo1+vX//Pd5FyeJSqYx6+MulRHTedYs j5lfLHQXXCdLt0PH/d8MxjAKklhVq/TjMI/Jlmkkap37Y8n3d0FM7VwS9H7GIbXwrrhI i7hA== X-Forwarded-Encrypted: i=1; AJvYcCXHMyv/HM4Ap4aapj46At2BzSi931469EO4NsG+Gt3CW8YorNRpDhzK9juLZGhfVpxFMahfMAu7nsBu@nongnu.org X-Gm-Message-State: AOJu0YyG9p5T7UUuCJ+p6LuHy4fRV8C5sUD2FNNVumCyTbc7G+4s0yan /JIVVOTAGJmvm2qhgU6Bn+Ej3n2126hK5i1SAyrRMvEkAasCO68uHshfJqsTrhU= X-Google-Smtp-Source: AGHT+IEKyIORfwqOkOmBehKLwE0qdAMn+mXsN+6Wkf2tLiMLc/o194vS7/tfOfQ0ccxc4CfdsFcS2g== X-Received: by 2002:a17:902:f54d:b0:20b:a8ad:9b0c with SMTP id d9443c01a7336-20c4e27a5c9mr2933115ad.3.1728318276589; Mon, 07 Oct 2024 09:24:36 -0700 (PDT) Received: from [192.168.0.4] (174-21-81-121.tukw.qwest.net. [174.21.81.121]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c138af8ccsm41481565ad.29.2024.10.07.09.24.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2024 09:24:36 -0700 (PDT) Message-ID: <77a9c9c5-9c6c-42cc-821f-1340e06ac685@linaro.org> Date: Mon, 7 Oct 2024 09:24:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/12] tcg/riscv: Add basic support for vector To: LIU Zhiwei , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, palmer@dabbelt.com, alistair.francis@wdc.com, dbarboza@ventanamicro.com, liwei1518@gmail.com, bmeng.cn@gmail.com, Huang Shiyuan , TANG Tiancheng References: <20241007025700.47259-1-zhiwei_liu@linux.alibaba.com> <20241007025700.47259-3-zhiwei_liu@linux.alibaba.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <20241007025700.47259-3-zhiwei_liu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/6/24 19:56, LIU Zhiwei wrote: > @@ -2100,6 +2136,30 @@ static void tcg_target_init(TCGContext *s) > { > tcg_target_available_regs[TCG_TYPE_I32] = 0xffffffff; > tcg_target_available_regs[TCG_TYPE_I64] = 0xffffffff; > + s->reserved_regs = 0; > + > + switch (riscv_lg2_vlenb) { > + case TCG_TYPE_V64: > + tcg_target_available_regs[TCG_TYPE_V64] = ALL_VECTOR_REGS; > + tcg_target_available_regs[TCG_TYPE_V128] = ALL_DVECTOR_REG_GROUPS; > + tcg_target_available_regs[TCG_TYPE_V256] = ALL_QVECTOR_REG_GROUPS; > + s->reserved_regs |= (~ALL_QVECTOR_REG_GROUPS & ALL_VECTOR_REGS); > + break; > + case TCG_TYPE_V128: > + tcg_target_available_regs[TCG_TYPE_V64] = ALL_VECTOR_REGS; > + tcg_target_available_regs[TCG_TYPE_V128] = ALL_VECTOR_REGS; > + tcg_target_available_regs[TCG_TYPE_V256] = ALL_DVECTOR_REG_GROUPS; > + s->reserved_regs |= (~ALL_DVECTOR_REG_GROUPS & ALL_VECTOR_REGS); > + break; > + default: > + /* Guaranteed by Zve64x. */ > + tcg_debug_assert(riscv_lg2_vlenb >= TCG_TYPE_V256); > + > + tcg_target_available_regs[TCG_TYPE_V64] = ALL_VECTOR_REGS; > + tcg_target_available_regs[TCG_TYPE_V128] = ALL_VECTOR_REGS; > + tcg_target_available_regs[TCG_TYPE_V256] = ALL_VECTOR_REGS; > + break; > + } Missing a check for host vector support. r~