From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com,
mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com,
jcody@redhat.com, ndevos@redhat.com, f4bug@amsat.org
Subject: Re: [Qemu-devel] [PATCH v2 02/15] sheepdog: Fix error handling in sd_snapshot_delete()
Date: Mon, 6 Mar 2017 13:25:29 -0600 [thread overview]
Message-ID: <77b194be-5cb5-472e-cc94-8533aba177b3@redhat.com> (raw)
In-Reply-To: <1488826849-32384-3-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On 03/06/2017 01:00 PM, Markus Armbruster wrote:
> As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an
> error and return negative errno on failure. It sometimes returns -1,
> and sometimes neglects to set an error. It also prints error messages
> with error_report(). Fix all that.
>
> Moreover, its handling of an attempt to delete an nonexistent snapshot
s/an nonexistent/a nonexistent/
> is wrong: it error_report()s and succeeds. Fix it to set an error and
> return -ENOENT instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> block/sheepdog.c | 41 +++++++++++++++++++----------------------
> 1 file changed, 19 insertions(+), 22 deletions(-)
R-by stands.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-06 19:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 19:00 [Qemu-devel] [PATCH v2 00/15] block: A bunch of fixes for Sheepdog and Gluster Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 01/15] sheepdog: Defuse time bomb in sd_open() error handling Markus Armbruster
2017-03-06 19:22 ` Eric Blake
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 02/15] sheepdog: Fix error handling in sd_snapshot_delete() Markus Armbruster
2017-03-06 19:25 ` Eric Blake [this message]
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 03/15] sheepdog: Fix error handling sd_create() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 04/15] sheepdog: Mark sd_snapshot_delete() lossage FIXME Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 05/15] sheepdog: Fix snapshot ID parsing in _open(), _create, _goto() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 06/15] sheepdog: Don't truncate long VDI name in _open(), _create() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 07/15] sheepdog: Report errors in pseudo-filename more usefully Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 08/15] sheepdog: Use SocketAddress and socket_connect() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 09/15] sheepdog: Implement bdrv_parse_filename() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 10/15] gluster: Drop assumptions on SocketTransport names Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 11/15] gluster: Don't duplicate qapi-util.c's qapi_enum_parse() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 12/15] gluster: Plug memory leaks in qemu_gluster_parse_json() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 13/15] qapi-schema: Rename GlusterServer to SocketAddressFlat Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 14/15] qapi-schema: Rename SocketAddressFlat's variant tcp to inet Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 15/15] sheepdog: Support blockdev-add Markus Armbruster
2017-03-07 13:09 ` [Qemu-devel] [PATCH v2 00/15] block: A bunch of fixes for Sheepdog and Gluster Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77b194be-5cb5-472e-cc94-8533aba177b3@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mitake.hitoshi@lab.ntt.co.jp \
--cc=namei.unix@gmail.com \
--cc=ndevos@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).