* [PATCH] kvm/i386: declare kvm_filter_msr() static
@ 2024-09-03 6:50 Ani Sinha
2024-09-03 13:23 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Ani Sinha @ 2024-09-03 6:50 UTC (permalink / raw)
To: Paolo Bonzini, Marcelo Tosatti; +Cc: Ani Sinha, kvm, qemu-devel
kvm_filer_msr() is only used from i386 kvm module. Make it static so that its
easy for developers to understand that its not used anywhere else.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
target/i386/kvm/kvm.c | 4 +++-
target/i386/kvm/kvm_i386.h | 3 ---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 2fa88ef1e3..11c7619bfd 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -93,6 +93,8 @@
#define MSR_BUF_SIZE 4096
static void kvm_init_msrs(X86CPU *cpu);
+static bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
+ QEMUWRMSRHandler *wrmsr);
const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
KVM_CAP_INFO(SET_TSS_ADDR),
@@ -5728,7 +5730,7 @@ static bool kvm_install_msr_filters(KVMState *s)
return true;
}
-bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
+static bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
QEMUWRMSRHandler *wrmsr)
{
int i;
diff --git a/target/i386/kvm/kvm_i386.h b/target/i386/kvm/kvm_i386.h
index 34fc60774b..26d7c57512 100644
--- a/target/i386/kvm/kvm_i386.h
+++ b/target/i386/kvm/kvm_i386.h
@@ -74,9 +74,6 @@ typedef struct kvm_msr_handlers {
QEMUWRMSRHandler *wrmsr;
} KVMMSRHandlers;
-bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
- QEMUWRMSRHandler *wrmsr);
-
#endif /* CONFIG_KVM */
void kvm_pc_setup_irq_routing(bool pci_enabled);
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm/i386: declare kvm_filter_msr() static
2024-09-03 6:50 [PATCH] kvm/i386: declare kvm_filter_msr() static Ani Sinha
@ 2024-09-03 13:23 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-09-03 13:23 UTC (permalink / raw)
To: Ani Sinha, Paolo Bonzini, Marcelo Tosatti; +Cc: kvm, qemu-devel
On 3/9/24 08:50, Ani Sinha wrote:
> kvm_filer_msr() is only used from i386 kvm module. Make it static so that its
> easy for developers to understand that its not used anywhere else.
>
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> target/i386/kvm/kvm.c | 4 +++-
> target/i386/kvm/kvm_i386.h | 3 ---
> 2 files changed, 3 insertions(+), 4 deletions(-)
> diff --git a/target/i386/kvm/kvm_i386.h b/target/i386/kvm/kvm_i386.h
> index 34fc60774b..26d7c57512 100644
> --- a/target/i386/kvm/kvm_i386.h
> +++ b/target/i386/kvm/kvm_i386.h
> @@ -74,9 +74,6 @@ typedef struct kvm_msr_handlers {
> QEMUWRMSRHandler *wrmsr;
> } KVMMSRHandlers;
Isn't it also valid for QEMURDMSRHandler, QEMUWRMSRHandler and
KVMMSRHandlers definitions?
>
> -bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
> - QEMUWRMSRHandler *wrmsr);
> -
> #endif /* CONFIG_KVM */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-03 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 6:50 [PATCH] kvm/i386: declare kvm_filter_msr() static Ani Sinha
2024-09-03 13:23 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).