From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Phil Dennis-Jordan <phil@philjordan.eu>
Cc: qemu-devel@nongnu.org, richard.henderson@linaro.org,
philmd@linaro.org, thuth@redhat.com, zhao1.liu@intel.com,
imammedo@redhat.com
Subject: Re: [PATCH 6/6] hw/vmapple: XHCI controller's interrupt mapping workaround for macOS
Date: Mon, 9 Dec 2024 20:47:05 +0900 [thread overview]
Message-ID: <77c34e50-6e71-46b3-b13e-d1711b51fadb@daynix.com> (raw)
In-Reply-To: <CAAibmn1sRa409YCPr6WQ1XmVBntkjh3EokKU1S6ywTwHMcV8xQ@mail.gmail.com>
On 2024/12/09 20:14, Phil Dennis-Jordan wrote:
>
>
> On Mon, 9 Dec 2024 at 07:26, Akihiko Odaki <akihiko.odaki@daynix.com
> <mailto:akihiko.odaki@daynix.com>> wrote:
>
> On 2024/12/09 4:16, Phil Dennis-Jordan wrote:
> > This change enables the new conditional interrupt mapping support
> > property on the vmapple machine type's integrated XHCI controller.
> > The macOS guest driver attempts to use event rings 1 and 2 on the
> XHCI
> > controller, despite there being only one (PCI pin) interrupt channel
> > available. With conditional interrupt mapping enabled, the XHCI
> > controller will only schedule events on interrupter 0 in PCI pin mode
> > or when only a single MSI vector is active.
>
> I think docs/system/arm/vmapple.rst also needs to be updated.
>
>
> Can you be more specific about what you think I should include? That
> file currently does not mention USB in any way, and if we set the new
> property in the machine type, there shouldn't be any need for manual
> configuration on the command line, should there?
I mistook the patch message for the documentation. The documentation
file is fine so there is no need for change here.
prev parent reply other threads:[~2024-12-09 11:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 19:16 [PATCH 0/6] hw/usb/hcd-xhci: Fixes, improvements, and macOS workaround Phil Dennis-Jordan
2024-12-08 19:16 ` [PATCH 1/6] hw/usb/hcd-xhci-pci: Don't trigger MSI on higher vector than allocated Phil Dennis-Jordan
2024-12-08 19:16 ` [PATCH 2/6] hw/usb/hcd-xhci-pci: Moves msi/msix properties from NEC to superclass Phil Dennis-Jordan
2024-12-09 6:27 ` Akihiko Odaki
2024-12-08 19:16 ` [PATCH 3/6] hw/usb/hcd-xhci-pci: Use event ring 0 if mapping unsupported Phil Dennis-Jordan
2024-12-09 6:28 ` Akihiko Odaki
2024-12-08 19:16 ` [PATCH 4/6] hw/usb/hcd-xhci-pci: Adds property for disabling mapping in IRQ mode Phil Dennis-Jordan
2024-12-09 6:19 ` Akihiko Odaki
2024-12-09 9:53 ` Phil Dennis-Jordan
2024-12-08 19:16 ` [PATCH 5/6] hw/usb/hcd-xhci-pci: Indentation fix Phil Dennis-Jordan
2024-12-08 19:16 ` [PATCH 6/6] hw/vmapple: XHCI controller's interrupt mapping workaround for macOS Phil Dennis-Jordan
2024-12-09 6:26 ` Akihiko Odaki
2024-12-09 11:14 ` Phil Dennis-Jordan
2024-12-09 11:47 ` Akihiko Odaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77c34e50-6e71-46b3-b13e-d1711b51fadb@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=imammedo@redhat.com \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).