From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Juan Quintela" <quintela@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>
Subject: Re: [PATCH 5/5] docs/devel: introduce some key concepts for QOM development
Date: Tue, 20 Jun 2023 12:10:36 +0200 [thread overview]
Message-ID: <77def85b-1a40-880e-0a54-ba5ae49b8f47@linaro.org> (raw)
In-Reply-To: <20230619171437.357374-6-alex.bennee@linaro.org>
On 6/19/23 19:14, Alex Bennée wrote:
> +As class initialisation cannot fail devices have an two additional
> +methods to handle the creation of dynamic devices. The ``realize``
Beginning with "as" feels like a continuation from something that has been omitted.
You've skipped over describing ``init`` entirely, and then assumed it.
> +The reverse function is ``unrealize`` and should be were clean-up
"and is where clean-up"
r~
next prev parent reply other threads:[~2023-06-20 10:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 17:14 [PATCH 0/5] docs/devel: improve API documentation for QOM Alex Bennée
2023-06-19 17:14 ` [PATCH 1/5] docs/devel: add some front matter to the devel index Alex Bennée
2023-06-20 9:57 ` Richard Henderson
2023-06-20 15:37 ` Peter Maydell
2023-06-19 17:14 ` [PATCH 2/5] include/migration: mark vmstate_register() as a legacy function Alex Bennée
2023-06-20 4:36 ` Philippe Mathieu-Daudé
2023-06-20 9:58 ` Richard Henderson
2023-06-20 14:19 ` Peter Xu
2023-06-21 19:29 ` Juan Quintela
2023-06-19 17:14 ` [PATCH 3/5] include/hw/qdev-core: fixup kerneldoc annotations (!COMPLETE) Alex Bennée
2023-06-20 10:02 ` Richard Henderson
2023-06-19 17:14 ` [PATCH 4/5] docs/devel: split qom-api reference into new file Alex Bennée
2023-06-20 4:38 ` Philippe Mathieu-Daudé
2023-06-20 10:03 ` Richard Henderson
2023-06-20 10:22 ` Philippe Mathieu-Daudé
2023-06-19 17:14 ` [PATCH 5/5] docs/devel: introduce some key concepts for QOM development Alex Bennée
2023-06-20 10:10 ` Richard Henderson [this message]
2023-06-20 15:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77def85b-1a40-880e-0a54-ba5ae49b8f47@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=leobras@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).