From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>,
Ashish Mittal <ashmit602@gmail.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, armbru@redhat.com,
jcody@redhat.com, famz@redhat.com, ashish.mittal@veritas.com,
stefanha@gmail.com, jferlan@redhat.com,
Buddhi.Madhav@veritas.com, Suraj.Singh@veritas.com,
Nitin.Jerath@veritas.com, peter.maydell@linaro.org,
rakesh.ranjan@veritas.com, venkatesha.mg@veritas.com,
Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com
Subject: Re: [Qemu-devel] [PATCH v9 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"
Date: Mon, 20 Feb 2017 14:49:06 +0100 [thread overview]
Message-ID: <77eb6c23-fc16-c7ad-c69b-afd6cae5e339@redhat.com> (raw)
In-Reply-To: <20170220100705.GD15874@redhat.com>
On 20/02/2017 11:07, Daniel P. Berrange wrote:
>> + if (qemu_uuid_is_null(&qemu_uuid)) {
> This is the wrong check - QEMU provides a 'qemu_uuid_set' boolean
> to determine if 'qemu_uuid' is set or not. If it is not set, then
> the code should return an error, not use a hardcoded uuid.
Or otherwise that hardcoded uuid should be all zeroes (UUID_NONE).
Paolo
>> + if (iio_init(QNIO_VERSION, vxhs_iio_callback, VXHS_UUID_DEF)) {
>> + return -ENODEV;
>> + }
next prev parent reply other threads:[~2017-02-20 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 22:30 [Qemu-devel] [PATCH v9 1/2] block/vxhs.c: Add support for a new block device type called "vxhs" Ashish Mittal
2017-02-19 22:30 ` [Qemu-devel] [PATCH v9 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs" Ashish Mittal
2017-02-20 10:07 ` [Qemu-devel] [PATCH v9 1/2] block/vxhs.c: Add support for a new block device type called "vxhs" Daniel P. Berrange
2017-02-20 13:49 ` Paolo Bonzini [this message]
2017-02-20 14:25 ` Jeff Cody
2017-02-20 14:29 ` Daniel P. Berrange
2017-02-20 14:21 ` Stefan Hajnoczi
2017-02-20 14:27 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77eb6c23-fc16-c7ad-c69b-afd6cae5e339@redhat.com \
--to=pbonzini@redhat.com \
--cc=Abhijit.Dey@veritas.com \
--cc=Buddhi.Madhav@veritas.com \
--cc=Ketan.Nilangekar@veritas.com \
--cc=Nitin.Jerath@veritas.com \
--cc=Suraj.Singh@veritas.com \
--cc=armbru@redhat.com \
--cc=ashish.mittal@veritas.com \
--cc=ashmit602@gmail.com \
--cc=berrange@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jferlan@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rakesh.ranjan@veritas.com \
--cc=stefanha@gmail.com \
--cc=venkatesha.mg@veritas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).