From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Greg Kurz <groug@kaod.org>
Subject: [PULL 05/13] tests/9pfs: Turn fs_mkdir() into a helper
Date: Tue, 20 Oct 2020 18:09:41 +0200 [thread overview]
Message-ID: <780f9da880e45280ce4e0a1b7c72fce618623a05.1603452058.git.qemu_oss@crudebyte.com> (raw)
In-Reply-To: <cover.1603452058.git.qemu_oss@crudebyte.com>
fs_mkdir() isn't a top level test function and thus shouldn't take
the "void *obj, void *data, QGuestAllocator *t_alloc" arguments.
Turn it into a helper to be used by test functions.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <160321018148.266767.15959608711038504029.stgit@bahia.lan>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
---
tests/qtest/virtio-9p-test.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index 3c187cdc08..2ea555fa04 100644
--- a/tests/qtest/virtio-9p-test.c
+++ b/tests/qtest/virtio-9p-test.c
@@ -972,11 +972,8 @@ static void fs_flush_ignored(void *obj, void *data, QGuestAllocator *t_alloc)
g_free(wnames[0]);
}
-static void fs_mkdir(void *obj, void *data, QGuestAllocator *t_alloc,
- const char *path, const char *cname)
+static void do_mkdir(QVirtio9P *v9p, const char *path, const char *cname)
{
- QVirtio9P *v9p = obj;
- alloc = t_alloc;
char **wnames;
char *const name = g_strdup(cname);
P9Req *req;
@@ -1031,7 +1028,7 @@ static void fs_create_dir(void *obj, void *data, QGuestAllocator *t_alloc)
g_assert(root_path != NULL);
do_attach(v9p);
- fs_mkdir(v9p, data, t_alloc, "/", "01");
+ do_mkdir(v9p, "/", "01");
/* check if created directory really exists now ... */
g_assert(stat(new_dir, &st) == 0);
--
2.20.1
next prev parent reply other threads:[~2020-10-23 11:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 11:20 [PULL 00/13] 9p queue 2020-10-23 Christian Schoenebeck
2020-10-20 16:09 ` [PULL 01/13] tests/9pfs: Factor out do_version() helper Greg Kurz
2020-10-23 15:32 ` Greg Kurz
2020-10-23 15:40 ` Christian Schoenebeck
2020-10-20 16:09 ` [PULL 04/13] tests/9pfs: Turn fs_readdir_split() into a helper Greg Kurz
2020-10-20 16:09 ` [PULL 02/13] tests/9pfs: Set alloc in fs_create_dir() Greg Kurz
2020-10-20 16:09 ` [PULL 03/13] tests/9pfs: Factor out do_attach() helper Greg Kurz
2020-10-20 16:09 ` Greg Kurz [this message]
2020-10-21 12:06 ` [PULL 06/13] tests/9pfs: simplify do_mkdir() Christian Schoenebeck
2020-10-21 12:17 ` [PULL 07/13] tests/9pfs: add local Tunlinkat directory test Christian Schoenebeck
2020-10-21 12:25 ` [PULL 08/13] tests/9pfs: add local Tlcreate test Christian Schoenebeck
2020-10-21 12:28 ` [PULL 09/13] tests/9pfs: add local Tunlinkat file test Christian Schoenebeck
2020-10-21 12:33 ` [PULL 10/13] tests/9pfs: add local Tsymlink test Christian Schoenebeck
2020-10-21 12:36 ` [PULL 11/13] tests/9pfs: add local Tunlinkat symlink test Christian Schoenebeck
2020-10-21 12:51 ` [PULL 12/13] tests/9pfs: add local Tlink test Christian Schoenebeck
2020-10-21 12:55 ` [PULL 13/13] tests/9pfs: add local Tunlinkat hard link test Christian Schoenebeck
2020-10-26 10:33 ` [PULL 00/13] 9p queue 2020-10-23 Peter Maydell
2020-10-26 12:48 ` Christian Schoenebeck
2020-10-26 21:25 ` Greg Kurz
2020-10-27 9:06 ` Dr. David Alan Gilbert
2020-10-27 10:21 ` Christian Schoenebeck
2020-10-27 10:26 ` Dr. David Alan Gilbert
2020-10-27 15:44 ` Christian Schoenebeck
2020-10-29 13:20 ` Peter Maydell
2020-10-29 13:48 ` Christian Schoenebeck
2020-10-29 13:57 ` Peter Maydell
2020-10-29 14:06 ` Christian Schoenebeck
2020-10-29 14:15 ` Peter Maydell
2020-10-29 14:31 ` Christian Schoenebeck
2020-10-29 14:52 ` Peter Maydell
2020-10-29 15:04 ` Daniel P. Berrangé
2020-10-29 17:27 ` Christian Schoenebeck
2020-10-29 17:29 ` Daniel P. Berrangé
2020-10-29 14:11 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=780f9da880e45280ce4e0a1b7c72fce618623a05.1603452058.git.qemu_oss@crudebyte.com \
--to=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).