From: Richard Henderson <richard.henderson@linaro.org>
To: Mateja Marjanovic <mateja.marjanovic@rt-rk.com>, qemu-devel@nongnu.org
Cc: arikalo@wavecomp.com, amarkovic@wavecomp.com, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 1/3] target/mips: Add emulation of MMI instruction PCPYH
Date: Mon, 25 Feb 2019 14:16:31 -0800 [thread overview]
Message-ID: <781179ad-b271-7cc6-4e59-bc81c478b9d0@linaro.org> (raw)
In-Reply-To: <1551111037-23411-2-git-send-email-mateja.marjanovic@rt-rk.com>
On 2/25/19 8:10 AM, Mateja Marjanovic wrote:
> + tcg_gen_andi_i64(t0, cpu_gpr[rt], mask);
tcg_gen_ext16u_i64.
> + tcg_gen_movi_i64(t1, 0);
> + tcg_gen_or_i64(t1, t0, t1);
> + tcg_gen_shli_i64(t0, t0, 16);
> + tcg_gen_or_i64(t1, t0, t1);
> + tcg_gen_shli_i64(t0, t0, 16);
> + tcg_gen_or_i64(t1, t0, t1);
> + tcg_gen_shli_i64(t0, t0, 16);
> + tcg_gen_or_i64(t1, t0, t1);
Much better as
tcg_gen_deposit(t0, t0, t0, 16, 48);
tcg_gen_deposit(t1, t0, t0, 32, 32);
r~
next prev parent reply other threads:[~2019-02-25 22:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 16:10 [Qemu-devel] [PATCH 0/3] target/mips: Add emulation of three MMI instructions Mateja Marjanovic
2019-02-25 16:10 ` [Qemu-devel] [PATCH 1/3] target/mips: Add emulation of MMI instruction PCPYH Mateja Marjanovic
2019-02-25 22:16 ` Richard Henderson [this message]
2019-02-25 16:10 ` [Qemu-devel] [PATCH 2/3] target/mips: Add emulation of MMI instruction PCPYLD Mateja Marjanovic
2019-02-25 22:20 ` Richard Henderson
2019-02-25 16:10 ` [Qemu-devel] [PATCH 3/3] target/mips: Add emulation of MMI instruction PCPYUD Mateja Marjanovic
2019-02-25 22:22 ` Richard Henderson
2019-02-25 16:44 ` [Qemu-devel] [PATCH 0/3] target/mips: Add emulation of three MMI instructions Aleksandar Rikalo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=781179ad-b271-7cc6-4e59-bc81c478b9d0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=mateja.marjanovic@rt-rk.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).