* [PATCH] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel
@ 2023-08-08 17:08 David Woodhouse
2023-08-14 12:33 ` Paul Durrant
0 siblings, 1 reply; 2+ messages in thread
From: David Woodhouse @ 2023-08-08 17:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Paul Durrant, Paolo Bonzini, Marcelo Tosatti, kvm
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
From: David Woodhouse <dwmw@amazon.co.uk>
XENFEAT_supervisor_mode_kernel shouldn't be set for HVM guests. It
confuses lscpu into thinking it's running in PVH mode.
No non-cosmetic effects have been observed so far.
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
Only really cosmetic. Don't feel strongly about whether it makes 8.1.
target/i386/kvm/xen-emu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/i386/kvm/xen-emu.c b/target/i386/kvm/xen-emu.c
index a8146115f0..b307c75713 100644
--- a/target/i386/kvm/xen-emu.c
+++ b/target/i386/kvm/xen-emu.c
@@ -267,7 +267,6 @@ static bool kvm_xen_hcall_xen_version(struct kvm_xen_exit *exit, X86CPU *cpu,
fi.submap |= 1 << XENFEAT_writable_page_tables |
1 << XENFEAT_writable_descriptor_tables |
1 << XENFEAT_auto_translated_physmap |
- 1 << XENFEAT_supervisor_mode_kernel |
1 << XENFEAT_hvm_callback_vector |
1 << XENFEAT_hvm_safe_pvclock |
1 << XENFEAT_hvm_pirqs;
--
2.34.1
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel
2023-08-08 17:08 [PATCH] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel David Woodhouse
@ 2023-08-14 12:33 ` Paul Durrant
0 siblings, 0 replies; 2+ messages in thread
From: Paul Durrant @ 2023-08-14 12:33 UTC (permalink / raw)
To: David Woodhouse, qemu-devel; +Cc: Paolo Bonzini, Marcelo Tosatti, kvm
On 08/08/2023 18:08, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> XENFEAT_supervisor_mode_kernel shouldn't be set for HVM guests. It
> confuses lscpu into thinking it's running in PVH mode.
>
> No non-cosmetic effects have been observed so far.
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
> Only really cosmetic. Don't feel strongly about whether it makes 8.1.
>
> target/i386/kvm/xen-emu.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Paul Durrant <paul@xen.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-14 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 17:08 [PATCH] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel David Woodhouse
2023-08-14 12:33 ` Paul Durrant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).