From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C27FC5479D for ; Thu, 12 Jan 2023 00:42:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFlaY-0007pG-KE; Wed, 11 Jan 2023 19:37:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFlaX-0007lq-CH for qemu-devel@nongnu.org; Wed, 11 Jan 2023 19:37:01 -0500 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFlaU-0001m1-JM for qemu-devel@nongnu.org; Wed, 11 Jan 2023 19:37:01 -0500 Received: by mail-pj1-x102c.google.com with SMTP id s13-20020a17090a6e4d00b0022900843652so314442pjm.1 for ; Wed, 11 Jan 2023 16:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eSQPKUBOKOMDxdyfRtg2sFo9EwO3mMVRHfPG9/4VvYQ=; b=IwvpSM/UNEJn/urUhSR4JF4MuqEOAkcSwW/hbiPDNJoaSQbgUgXtK5CLaf+DbWIvMc 4bg/oInXAwHuIWE0GE0/0ox3OTHsqzLXIw1RNA9+0JOvSwUIAiV457+BOiAyjW98IDyG NLyLqz/rho/gOHXApR56PG0XbiAlRbSJHqC+UuR/BpNnMvPuyDcbhO9dDXUIc8us/qqX 7CNOkHmyk7hkXlDLJbyAfFkoC4IITSKjGGPWs7J4szv5Vu7fZ1w+h/2veS7qcmHqTI4H k2vHsbUVvKJukhJzP82pIQhOk/kJb+hQWSqoZpGcgeAS+E2r5TouJywzsGOB1wFfR8Q1 rEzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eSQPKUBOKOMDxdyfRtg2sFo9EwO3mMVRHfPG9/4VvYQ=; b=vDYrDGtBJOB3I25x4F4OJ6zxl7kEmCiZJQ9cWi1yRop4HYdXphdrbpGJsWeVTRdh/a rG7sUAxxST4+jO2m6nNYw+lROKeqoaAGLuUcboZGxMG3ulF+i4gs04pT87mnpOW0Kgdy EmhEzy+wmkoBOC5uaOsetW7NOiWo1pZqDrxPabhS7Ni0XNGLpU6GpQ+y4d2QTNEjs4oi Wz2NVUOz/jWa4qECuVo6GbXH9Jn41msnSvb0qULy1LNl5g3pv2xY9bJmYRxV3j+NrHpt 8WoD267IFET/Ij0ejs9Zlo5NV0Hr6jbL1XsOlKNSxjr9r6hKN5XLyzimczwmUy2UmkuF ZQVg== X-Gm-Message-State: AFqh2krM6ykpOoGjoyqOciXKmW64LQRaN9h6tMUa/DCZOTQyyfQlEo3S 2i991kU4+XNhWRM9y30K86HETQ== X-Google-Smtp-Source: AMrXdXtK0qJQp/xXrYvUywr1SNH5yDAiPRksxahBM6Im72zUSDoLZE4xDoL4vTLg7j0kaoZE6pUPxA== X-Received: by 2002:a17:902:c495:b0:193:ea7:52b8 with SMTP id n21-20020a170902c49500b001930ea752b8mr21180927plx.41.1673483817814; Wed, 11 Jan 2023 16:36:57 -0800 (PST) Received: from [192.168.5.146] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id jd9-20020a170903260900b00186727e5f5csm10743237plb.248.2023.01.11.16.36.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 16:36:56 -0800 (PST) Message-ID: <782e40cf-532b-8148-1512-1b56668977e1@linaro.org> Date: Wed, 11 Jan 2023 09:50:25 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/4] bulk: Replace TARGET_FMT_plx -> HWADDR_PRIx Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-block@nongnu.org, BALATON Zoltan References: <20230111083909.42624-1-philmd@linaro.org> <20230111083909.42624-4-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230111083909.42624-4-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/11/23 00:39, Philippe Mathieu-Daudé wrote: > The 'hwaddr' type is defined in "exec/hwaddr.h" as: > > hwaddr is the type of a physical address > (its size can be different from 'target_ulong'). > > All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx: > > $ fgrep define include/exec/hwaddr.h > #define HWADDR_H > #define HWADDR_BITS 64 > #define HWADDR_MAX UINT64_MAX > #define TARGET_FMT_plx "%016" PRIx64 > ^^^^^^ > #define HWADDR_PRId PRId64 > #define HWADDR_PRIi PRIi64 > #define HWADDR_PRIo PRIo64 > #define HWADDR_PRIu PRIu64 > #define HWADDR_PRIx PRIx64 > #define HWADDR_PRIX PRIX64 > > Since hwaddr's size can be*different* from target_ulong, it is > very confusing to read one of its format using the 'TARGET_FMT_' > prefix, normally used for the target_long / target_ulong types: > > $ fgrep TARGET_FMT_ include/exec/cpu-defs.h > #define TARGET_FMT_lx "%08x" > #define TARGET_FMT_ld "%d" > #define TARGET_FMT_lu "%u" > #define TARGET_FMT_lx "%016" PRIx64 > #define TARGET_FMT_ld "%" PRId64 > #define TARGET_FMT_lu "%" PRIu64 > > Apparently this format was missed during commit a8170e5e97 > ("Rename target_phys_addr_t to hwaddr"), so complete it by > doing a bulk-replacement to '"%016" HWADDR_PRIx' using: > > $ sed -i -E \ > -e 's/" ?TARGET_FMT_plx ?"/%016" HWADDR_PRIx "/g' \ > -e 's/" ?TARGET_FMT_plx/%016" HWADDR_PRIx/g' \ > -e 's/TARGET_FMT_plx ?"/"%016" HWADDR_PRIx "/g' \ > $(git grep -l TARGET_FMT_plx) > > and removing the definition from "exec/hwaddr.h". > > Suggested-by: BALATON Zoltan > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Richard Henderson r~