qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] configure: Test that gio libs from pkg-config work
Date: Mon, 19 Oct 2020 15:26:00 +0200	[thread overview]
Message-ID: <783fb422-5561-e113-9d25-a3079dbd2a41@redhat.com> (raw)
In-Reply-To: <CAFEAcA_nKtDRzV9YUdMoNXRV_o_rp-y2aai3zH2JsM7yWhJ9eg@mail.gmail.com>

On 19/10/20 13:16, Peter Maydell wrote:
> On Mon, 28 Sep 2020 at 17:42, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 28/09/20 18:04, Peter Maydell wrote:
>>> I wanted a statically-linked system emulation binary (which, yes,
>>> I know is not really something we support :-)). I got one with
>>> suitably liberal use of --disable-foo configure options, and
>>> this was the only thing I couldn't work around that way.
>>> The patch is needed because there's no --disable-gio. I suppose
>>> we could add that instead (or as well)...
>>> Possibly meson offers a nicer way to do this, but this was
>>> simple and gnutls is doing the check this way already.
>>
>> No, you'd get just that warning about static libraries not being
>> available; so I think either this patch or --disable-gio is fine.
> 
> Could I have a Reviewed-by: if you're happy with this patch?

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>



  reply	other threads:[~2020-10-19 13:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 16:04 [PATCH] configure: Test that gio libs from pkg-config work Peter Maydell
2020-09-28 16:42 ` Paolo Bonzini
2020-10-19 11:16   ` Peter Maydell
2020-10-19 13:26     ` Paolo Bonzini [this message]
2020-10-19 11:27 ` Philippe Mathieu-Daudé
  -- strict thread matches above, loose matches on Subject: below --
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
2020-10-12 15:33 ` [PATCH] configure: Test that gio libs from pkg-config work Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=783fb422-5561-e113-9d25-a3079dbd2a41@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).