qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Eduardo Habkost <eduardo@habkost.net>
Subject: Re: [PATCH v2 0/2] target/i386: fix hang when using slow path for ptw_setl
Date: Fri, 25 Oct 2024 10:59:45 -0700	[thread overview]
Message-ID: <784b2fab-a7ad-4e52-a3bc-60351cb7ecf2@linaro.org> (raw)
In-Reply-To: <20241025175334.2549425-1-pierrick.bouvier@linaro.org>

On 10/25/24 10:53, Pierrick Bouvier wrote:
> Most of the details are available in first patch. Second one is there to ensure
> we'll have a useful error message if start_exclusive is called from cpu_exec
> again.
> 
> I'm a bit puzzled that we never triggered this hang before. Is there something
> wrong with the potential slow path for ptw_setl, or is it simply very uncommon?
> 
> v2:
> - get current cpu from local variable instead of current_cpu global var.
> - change condition to check cpu is running as current_cpu will never be NULL.
> 
> Pierrick Bouvier (2):
>    target/i386: fix hang when using slow path for ptw_setl
>    cpu: ensure we don't call start_exclusive from cpu_exec
> 
>   cpu-common.c                         | 3 +++
>   target/i386/tcg/sysemu/excp_helper.c | 4 ++++
>   2 files changed, 7 insertions(+)
> 

Pushed from my old branch (same as v1), please see v3 instead.


      parent reply	other threads:[~2024-10-25 18:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 17:53 [PATCH v2 0/2] target/i386: fix hang when using slow path for ptw_setl Pierrick Bouvier
2024-10-25 17:53 ` [PATCH v2 1/2] " Pierrick Bouvier
2024-10-25 17:53 ` [PATCH v2 2/2] cpu: ensure we don't call start_exclusive from cpu_exec Pierrick Bouvier
2024-10-25 17:59 ` Pierrick Bouvier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=784b2fab-a7ad-4e52-a3bc-60351cb7ecf2@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=eduardo@habkost.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).