From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evYjb-00065v-OS for qemu-devel@nongnu.org; Mon, 12 Mar 2018 21:28:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evYja-0003FR-VH for qemu-devel@nongnu.org; Mon, 12 Mar 2018 21:28:11 -0400 References: <20180306204819.11266-1-stefanha@redhat.com> <20180308173742.GH2769@stefanha-x1.localdomain> From: Eric Blake Message-ID: <784c7895-d140-8236-2ca5-a88946853b09@redhat.com> Date: Mon, 12 Mar 2018 20:27:48 -0500 MIME-Version: 1.0 In-Reply-To: <20180308173742.GH2769@stefanha-x1.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] block: fix nbd-server-stop crash after blockdev-snapshot-sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, Kevin Wolf , Max Reitz , qemu-block@nongnu.org, Stefano Panella On 03/08/2018 11:37 AM, Stefan Hajnoczi wrote: > On Wed, Mar 07, 2018 at 05:27:45PM -0600, Eric Blake wrote: >> On 03/06/2018 02:48 PM, Stefan Hajnoczi wrote: >>> The blockdev-snapshot-sync command uses bdrv_append() to update all parents to >>> point at the external snapshot node. This breaks BlockBackend's >>> blk_add/remove_aio_context_notifier(), which doesn't expect a BDS change. >>> >> Whose tree should this series go through? MAINTAINERS didn't flag it as >> directly touching any files that normally affect my NBD queue, but given >> that the iotest that reproduces the problem uses NBD, I'm fine if you want >> it to go through me. > > Good question. Max and Kevin maintain block/block-backend.c so one of > them should be happy with this series before it gets merged. > > When a patch affects multiple trees, the last sub-maintainer to review > it can do the merge. > > So if they have already posted their R-b when you are finished, then > feel free to merge it! And vice versa. Max has reviewed, so this is now queued on my NBD tree, pull request to come shortly. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org