From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3722C433E0 for ; Tue, 12 Jan 2021 00:25:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6362922D49 for ; Tue, 12 Jan 2021 00:25:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6362922D49 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz7Um-0002UO-I1 for qemu-devel@archiver.kernel.org; Mon, 11 Jan 2021 19:25:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz7Po-0007Iu-NB for qemu-devel@nongnu.org; Mon, 11 Jan 2021 19:20:04 -0500 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:40396) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kz7Pl-00064o-OK for qemu-devel@nongnu.org; Mon, 11 Jan 2021 19:20:04 -0500 Received: by mail-pj1-x102c.google.com with SMTP id m5so550417pjv.5 for ; Mon, 11 Jan 2021 16:20:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DNp5GAfjGCpmYqnBW3PDn1/z8JA2tW0PufcKIWKap/c=; b=YuxZN00mLa7r7vPsBADODzzyQ/dkFUvezQpPQc/6IFPygR4gToDDopz64AW5twVqQh XfuMc8tDesUFhzX1jwexJ2PrYvAc52aR10db0WuOx+GEn2oms94XVD7e9o1ebTroIhdG Og4J/RMq2lRCYLfs3Kd3vY74cyAStRNaizEwEjWqsi517nR9mQAK5DME4ONOlep/vcRV arbKmbeITrT2eHAjCQFAUybpuHpxy5yGJPG1pIPUBLGP6S9eu1OVFrlPRYg28hEfbzSS Bs1B9iX/n7bVrqLDt9jRpKsrf7umc3ULFt9fKvrKWiz/2KH3wsJOVMZGfbE9enclPpXR Zl7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DNp5GAfjGCpmYqnBW3PDn1/z8JA2tW0PufcKIWKap/c=; b=en519Josg1tbbbbIB/329SE1nPT/f899f7E1J7ODCxk96upuUyqA5grPch2i0YvvgE xM+nW9KgXIuT0daJKBnf2L6NbcX67oOH98LEadtTW1fwTzflAl044yzvWGtVPlsgGYtt zOdCEcqCI3jbtaxWL7d2z8PtShDw71dzr7mQFwXn4ph0Yu6mj8YjUK4CWe8r67/A4088 OSmK7RCBdQOdcGU7piKwH9Alp7r4jTgzTbJkPz3hGIIxwYrwG8/AC1qe4sBWEZ20yj3B WgRlcObHbaYfSa2ftLOS6SnTtI8iGXNOL6rOsOOglDFBA43gOw69bIfjmR+eYWLNvd4r UiUQ== X-Gm-Message-State: AOAM531Pr86doMSVILy70YE+d/n796A1uMmhynYTiQI8hZGVAXgCknKl gcUCBdY6DTznKqELrl01J9/WaLOKHD6a2Q== X-Google-Smtp-Source: ABdhPJz4sswzpkJ+dKFF3nqnfquZYFHOCSXfvPQpCojh2mlgQwwg5mMwUaXDUDL6nPxsb2HXkq3B6Q== X-Received: by 2002:a17:90a:d806:: with SMTP id a6mr1481826pjv.170.1610410799705; Mon, 11 Jan 2021 16:19:59 -0800 (PST) Received: from [10.25.18.119] (rrcs-173-197-107-21.west.biz.rr.com. [173.197.107.21]) by smtp.gmail.com with ESMTPSA id j3sm602656pjs.50.2021.01.11.16.19.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 16:19:59 -0800 (PST) Subject: Re: [PATCH 14/18] target/arm: secure stage 2 translation regime To: remi.denis.courmont@huawei.com, qemu-arm@nongnu.org References: <3337797.iIbC2pHGDl@basile.remlab.net> <20201218103759.19929-14-remi.denis.courmont@huawei.com> From: Richard Henderson Message-ID: <785079cf-fb1f-a380-00bc-783126090a07@linaro.org> Date: Mon, 11 Jan 2021 14:19:55 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201218103759.19929-14-remi.denis.courmont@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/18/20 12:37 AM, remi.denis.courmont@huawei.com wrote: > @@ -11286,8 +11299,10 @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, > > ap = extract32(attrs, 4, 2); > > - if (mmu_idx == ARMMMUIdx_Stage2) { > - ns = true; > + if (mmu_idx == ARMMMUIdx_Stage2 || mmu_idx == ARMMMUIdx_Stage2_S) { > + if (mmu_idx == ARMMMUIdx_Stage2) { > + ns = true; > + } > xn = extract32(attrs, 11, 2); Does this want an unconditional ns = mmu_idx == ARMMMUIdx_Stage2; When can ns be true and mmu_idx == ARMMMUIdx_Stage2_S? Otherwise, Reviewed-by: Richard Henderson r~