Re: [PATCH 10/11] bochs-rs: Add bochs block driver reimplementation in Rust

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 12/2/25 13:59, Kevin Wolf wrote:
> Am 12.02.2025 um 08:45 hat Philippe Mathieu-Daudé geschrieben:
>> On 11/2/25 22:43, Kevin Wolf wrote:
>>> This adds a separate block driver for the bochs image format called
>>> 'bochs-rs' so that for the moment both the C implementation and the Rust
>>> implementation can be present in the same build. The intention is to
>>> remove the C implementation eventually and rename this one into 'bochs'.
>>> This can only happen once Rust can be a hard build dependency for QEMU.
>>>
>>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>>> ---
>>>    rust/block/Cargo.toml    |   2 +-
>>>    rust/block/src/bochs.rs  | 296 +++++++++++++++++++++++++++++++++++++++
>>>    rust/block/src/driver.rs |   5 -
>>>    rust/block/src/lib.rs    |   1 +
>>>    4 files changed, 298 insertions(+), 6 deletions(-)
>>>    create mode 100644 rust/block/src/bochs.rs
>>
>>
>>> diff --git a/rust/block/src/bochs.rs b/rust/block/src/bochs.rs
>>> new file mode 100644
>>> index 0000000000..388ac5ef03
>>> --- /dev/null
>>> +++ b/rust/block/src/bochs.rs
>>> @@ -0,0 +1,296 @@
>>> +// SPDX-License-Identifier: MIT
>>> +/*
>>> + * Block driver for the various disk image formats used by Bochs
>>> + * Currently only for "growing" type in read-only mode
>>> + *
>>> + * Copyright (c) 2005 Alex Beregszaszi
>>> + * Copyright (c) 2024 Red Hat
>>> + *
>>> + * Authors:
>>> + *   Alex Beregszaszi
>>> + *   Kevin Wolf <kwolf@redhat.com>
>>> + *
>>> + * Permission is hereby granted, free of charge, to any person obtaining a copy
>>> + * of this software and associated documentation files (the "Software"), to deal
>>> + * in the Software without restriction, including without limitation the rights
>>> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
>>> + * copies of the Software, and to permit persons to whom the Software is
>>> + * furnished to do so, subject to the following conditions:
>>> + *
>>> + * The above copyright notice and this permission notice shall be included in
>>> + * all copies or substantial portions of the Software.
>>> + *
>>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
>>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
>>> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
>>> + * THE SOFTWARE.
>>> + */
>>
>> As an addition, we don't have to add the full license boilerplate IMO...
> 
> IANAL, but the license says "The above copyright notice and this
> permission notice shall be included in all copies or substantial
> portions of the Software.", so keeping it feels like the safe option.

OK (and as Daniel clarified, you consider your work a derivative).