From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2568C02198 for ; Wed, 12 Feb 2025 13:52:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tiDA6-0001b2-B9; Wed, 12 Feb 2025 08:52:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tiDA4-0001aA-4p for qemu-devel@nongnu.org; Wed, 12 Feb 2025 08:52:20 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tiDA2-0004BX-7V for qemu-devel@nongnu.org; Wed, 12 Feb 2025 08:52:19 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-38dc73cc5acso603087f8f.0 for ; Wed, 12 Feb 2025 05:52:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739368336; x=1739973136; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mDGElKK7O6ztUPks6RUd5Ce9zA7qI1BjY7ade2bOauY=; b=C3x0nWmWDl8aS7WW33xZ7StF07t/XgXkCocQcmP5clLnl2ofdDP26Je7dBfsIK4Lwd Jgz8nTAonugKSDqkPlfnjmnYzPOm4JaJBxMFuGFmdGdHNJab+02+sTk0KH9wn5QYAMU3 KMNizQpmH+Uzjv7CK1aM/TK8Gug/Q3k2kQAVtc7ZYsOfQqcZQ5r+7CFfmR+Kq0oQDhjn t76yuNgnjaPaBwaEq4+YM25mfVawMlXBsXc1PlfnZe01o8JPMprcF6jYy0jdBtlZax/e SEZevAjl6ViAuUptEd6y0x+RphEnDLqVpdSUNZxe7LWB9mMzEPs22hglLYoD0qgvv4g7 3Q/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739368336; x=1739973136; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mDGElKK7O6ztUPks6RUd5Ce9zA7qI1BjY7ade2bOauY=; b=aDSNnLVJrHdAXRIkKpMrCU96FBMrT0jZ56WyWdgzykNFAN16nylEFyBavqjKn6tH04 VcWSlWAStqb2Yiu59lwuhOz8/DRO4qjze3jYmTjx40/GWhGWJv8MvS7wbx7jnsX2ZbXq yJjHHUWRHO11E/yEiC1cxbrB3Rh3IzZE0x23qWyQPJjghAuzcwxRyYgw91SYlnSeV7Vy MPNbn7oycovSmysTFys+TvEO+vPzFmJEDKw498rKT1YIywN3VVjumZNg7Ka+GEUFx9OC 3lCJ+n+H0HtvryP90BcoszpqHBprR8a6M/j9YJ57BV/mKL8lgEbkZWWkHQ0N26GYUvFe 5UpQ== X-Forwarded-Encrypted: i=1; AJvYcCUhJeXvSpPnczJZVIGRINO05MIZazfSFI5ZmYtX3poXgFzKMijc5vGhA09ie8WE0KMEamdyTS+qjZmn@nongnu.org X-Gm-Message-State: AOJu0YzBZDu0GrVVbNCMPusBUA5fLbT1HHEOHisZIHcTXNiuSWSYHL1A xjHdQN3yuoz71fI3aJ8USCNj09gaNBFRqUhtVYAzM44nETcEYKtxUdazCRZE8UQ= X-Gm-Gg: ASbGncvWO4VhdM0RTtyEzjfcKJ5lwnuL0YubDQDMch2DMaiv/90gbO+5DFC0AVUUaGt WtaplioJTXs7NmL/q2CKkG/EVhDy6PIPzKDb3DHQ4H6BIhekYERU6XY/TRZJ1q6yguq/mNNtxF5 SJeq5jJGECQZRY/ljcqZlyy393qsZ8QmJ7noi8qYMbiPeBQH6zPsb25krqb4TkU38jxEd6npeuh sT1Bk7wlVpcz2s2eiFz4Ye3fN4a4YHii62AUClvqR3bhd3WVn+nVaoABlAAgWerYyQrPjiyOPw3 jr4D5mjvcNltwLoVVRkModpsCMwA/xEe3YKxTyZYQwhDK+72LI4Jfpmbt2U= X-Google-Smtp-Source: AGHT+IHwZFqqEYnmSu/nxYh/dqHKV3zekZCKJGDzP5NFgsKQmkY1cau9nHuSFsjlKIk7FFKXu3Pz1Q== X-Received: by 2002:a05:6000:156c:b0:38d:c88e:d57b with SMTP id ffacd0b85a97d-38de43e921fmr7468669f8f.26.1739368336272; Wed, 12 Feb 2025 05:52:16 -0800 (PST) Received: from [192.168.69.198] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38deb34980esm1857133f8f.97.2025.02.12.05.52.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Feb 2025 05:52:15 -0800 (PST) Message-ID: <7852ec2e-bc14-420e-a4bc-0230f3141980@linaro.org> Date: Wed, 12 Feb 2025 14:52:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/11] bochs-rs: Add bochs block driver reimplementation in Rust To: Kevin Wolf Cc: qemu-block@nongnu.org, hreitz@redhat.com, pbonzini@redhat.com, manos.pitsidianakis@linaro.org, qemu-devel@nongnu.org, qemu-rust@nongnu.org References: <20250211214328.640374-1-kwolf@redhat.com> <20250211214328.640374-11-kwolf@redhat.com> <0e3d0835-c216-4f8c-8b97-e849ecb5ca47@linaro.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/2/25 13:59, Kevin Wolf wrote: > Am 12.02.2025 um 08:45 hat Philippe Mathieu-Daudé geschrieben: >> On 11/2/25 22:43, Kevin Wolf wrote: >>> This adds a separate block driver for the bochs image format called >>> 'bochs-rs' so that for the moment both the C implementation and the Rust >>> implementation can be present in the same build. The intention is to >>> remove the C implementation eventually and rename this one into 'bochs'. >>> This can only happen once Rust can be a hard build dependency for QEMU. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> rust/block/Cargo.toml | 2 +- >>> rust/block/src/bochs.rs | 296 +++++++++++++++++++++++++++++++++++++++ >>> rust/block/src/driver.rs | 5 - >>> rust/block/src/lib.rs | 1 + >>> 4 files changed, 298 insertions(+), 6 deletions(-) >>> create mode 100644 rust/block/src/bochs.rs >> >> >>> diff --git a/rust/block/src/bochs.rs b/rust/block/src/bochs.rs >>> new file mode 100644 >>> index 0000000000..388ac5ef03 >>> --- /dev/null >>> +++ b/rust/block/src/bochs.rs >>> @@ -0,0 +1,296 @@ >>> +// SPDX-License-Identifier: MIT >>> +/* >>> + * Block driver for the various disk image formats used by Bochs >>> + * Currently only for "growing" type in read-only mode >>> + * >>> + * Copyright (c) 2005 Alex Beregszaszi >>> + * Copyright (c) 2024 Red Hat >>> + * >>> + * Authors: >>> + * Alex Beregszaszi >>> + * Kevin Wolf >>> + * >>> + * Permission is hereby granted, free of charge, to any person obtaining a copy >>> + * of this software and associated documentation files (the "Software"), to deal >>> + * in the Software without restriction, including without limitation the rights >>> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell >>> + * copies of the Software, and to permit persons to whom the Software is >>> + * furnished to do so, subject to the following conditions: >>> + * >>> + * The above copyright notice and this permission notice shall be included in >>> + * all copies or substantial portions of the Software. >>> + * >>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR >>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, >>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL >>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER >>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, >>> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN >>> + * THE SOFTWARE. >>> + */ >> >> As an addition, we don't have to add the full license boilerplate IMO... > > IANAL, but the license says "The above copyright notice and this > permission notice shall be included in all copies or substantial > portions of the Software.", so keeping it feels like the safe option. OK (and as Daniel clarified, you consider your work a derivative).