From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B1ECC28EBD for ; Sun, 9 Jun 2019 12:19:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DADEB2070B for ; Sun, 9 Jun 2019 12:19:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DADEB2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZwn4-0007QL-3E for qemu-devel@archiver.kernel.org; Sun, 09 Jun 2019 08:19:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38675) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZwm1-0006zr-1i for qemu-devel@nongnu.org; Sun, 09 Jun 2019 08:18:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZwlz-00009B-S9 for qemu-devel@nongnu.org; Sun, 09 Jun 2019 08:18:08 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:45127) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZwlz-00005W-Il for qemu-devel@nongnu.org; Sun, 09 Jun 2019 08:18:07 -0400 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.119]) with ESMTPSA (Nemesis) id 1Mn1mb-1grUfY266h-00k9Hi; Sun, 09 Jun 2019 14:12:55 +0200 To: Lucien Murray-Pitts , qemu-devel@nongnu.org References: <20190609105154.GA16755@localhost.localdomain> From: Laurent Vivier Openpgp: preference=signencrypt Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <7856b300-b58c-e8f7-ebbd-f378db19a9d6@vivier.eu> Date: Sun, 9 Jun 2019 14:12:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190609105154.GA16755@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:TKDfvJXUhg8qKEcDq8gM/I5efwFt9m7bEJTOaOZaKx8beorgC+U qC0vKc75JNfrLHdAiBb5YCbu89i3myAH9eZhvKvQGzPy89u2EznINqT6mjMXbn619LPy8jw t1oOTFLOw644kcI5roHXTtI/2gA+oZ/ujwWg/FT7G6KXNupjP3l6ESPKrITDHFiXXLtZNpZ 7EruI+i4rt5Tw2IkZM/OA== X-UI-Out-Filterresults: notjunk:1;V03:K0:PYMaAqHoJIw=:o0tPEe52JXDiKwQFVnHbjw xL31cubES60AgV+4zqKieoloEW6FO+BdVSFIbpRNVXsN40/bXU5k6rREoDSGTNPZfZPpIrBtT kxOD880C8XJFFdG8xvvl1Y+sc7iGaIt3/htItvhyNxvClqRfxEsZN7C2xlHrQbsx96QaAorwy tibDBFO1B900MibxY/uNEuxCS+JGQFJOD+RXGvSeDwn8fX/4ZAvAdrPWk6l8yKO38SzEkddMT JhfVcvRrQksMAEyenej20ijABb+g9Wfopbp3yZMjkBsRzyumSYpkQOIYCmmPfxtko4NtbY+AA 3Tx7xRJF+UtGK1/ypT8cCU3lIkiA2n1NHlRfyxGqg+IZy5VnUwL4Z3Mi7RXMMW4OHJ6BGsSOz Mc9q8GCa7C8jB/0PSFolRbIlOPj+RoYBCEFsKR8s/NK+tjDxk+BUEQfxl4Gtc+HYrEvxyUU/l MGpEPI5qvDRIgycbn7GXE1DZStrqpzYmsgGrcIMxNS/lrUtuh2Upa5i1iyEsNzrCERXSynrPp 6lc6C1c9mlJBGuTgiKM7GL3WNg+Pdlb6GoObHH2C0a8v54JxZjGaRPU0cI45O2HTPLMZ/6eIQ hO0pcZOQTDN/KTUnTxYVB2sc7nKiPmyoMbRj5d9T+RNGzl3rmMcgMfTWcPqy7aaevZ/Y+Bc0v D7kTGYwYFxg8f6f5FpzUcyKVhEA5FN50NtaawJdKaG00lUFOLJj5MY5JFkjkQTsV+WiUFtKG0 seQUseghFV6K0iax+70DPKXz+rz8Rkn/UPeyqzYX1X/qDQ4GJzv3iSDfTeE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.74 Subject: Re: [Qemu-devel] [PATCH v3] The m68k gdbstub SR reg request doesnt include Condition-Codes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 09/06/2019 à 12:51, Lucien Murray-Pitts a écrit : > The register request via gdbstub would return the SR part > which contains the Trace/Master/IRQ state flags, but > would be missing the CR (Condition Register) state bits. > > This fix adds this support by merging them in the m68k > specific gdbstub handler m68k_cpu_gdb_read_register for SR register. > > Signed-off-by: Lucien Murray-Pitts > --- > > Notes: > v1->v2 > - removed my superfluous braces > - slightly amended the commit message > > v2->v3 > - removed my incorrect use of code block in a switch > > target/m68k/gdbstub.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/m68k/gdbstub.c b/target/m68k/gdbstub.c > index fd2bb46c42..6e7f3b8980 100644 > --- a/target/m68k/gdbstub.c > +++ b/target/m68k/gdbstub.c > @@ -36,7 +36,8 @@ int m68k_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n) > } else { > switch (n) { > case 16: > - return gdb_get_reg32(mem_buf, env->sr); > + /* SR is made of SR+CCR, CCR is many 1bit flags so uses helper */ > + return gdb_get_reg32(mem_buf, env->sr | cpu_m68k_get_ccr(env)); > case 17: > return gdb_get_reg32(mem_buf, env->pc); > } > Reviewed-by: Laurent Vivier