From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>,
Aleksandar Markovic <aleksandar.m.mail@gmail.com>,
Finn Thain <fthain@telegraphics.com.au>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-stable@nongnu.org" <qemu-stable@nongnu.org>
Subject: Re: [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation
Date: Wed, 19 Feb 2020 09:27:56 +0100 [thread overview]
Message-ID: <785abd9e-a02d-7850-ddfd-b8bc0fa146cd@redhat.com> (raw)
In-Reply-To: <67b0565e-9f2c-7ef0-aca6-01cba798fad4@vivier.eu>
On 2/19/20 8:55 AM, Laurent Vivier wrote:
> Le 19/02/2020 à 02:57, Aleksandar Markovic a écrit :
>> 2:54 AM Sre, 19.02.2020. Aleksandar Markovic
>> <aleksandar.m.mail@gmail.com <mailto:aleksandar.m.mail@gmail.com>> је
>> написао/ла:
>>>
>>> 2:06 AM Sre, 19.02.2020. Finn Thain <fthain@telegraphics.com.au
>> <mailto:fthain@telegraphics.com.au>> је написао/ла:
>>>>
>>>> On Tue, 18 Feb 2020, Aleksandar Markovic wrote:
>>>>
>>>>> On Wednesday, January 29, 2020, Finn Thain
>> <fthain@telegraphics.com.au <mailto:fthain@telegraphics.com.au>>
>>>>> wrote:
>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> There are bugs in the emulated dp8393x device that can stop packet
>>>>>> reception in a Linux/m68k guest (q800 machine).
>>>>>>
>>>>>> With a Linux/m68k v5.5 guest (q800), it's possible to remotely
>> trigger
>>>>>> an Oops by sending ping floods.
>>>>>>
>>>>>> With a Linux/mips guest (magnum machine), the driver fails to probe
>>>>>> the dp8393x device.
>>>>>>
>>>>>> With a NetBSD/arc 5.1 guest (magnum), the bugs in the device can be
>>>>>> fatal to the guest kernel.
>>>>>>
>>>>>> Whilst debugging the device, I found that the receiver algorithm
>>>>>> differs from the one described in the National Semiconductor
>>>>>> datasheet.
>>>>>>
>>>>>> This patch series resolves these bugs.
>>>>>>
>>>>>> AFAIK, all bugs in the Linux sonic driver were fixed in Linux v5.5.
>>>>>> ---
>>>>>
>>>>>
>>>>> Herve,
>>>>>
>>>>> Do your Jazz tests pass with these changes?
>>>>>
>>>>
>>>> AFAIK those tests did not expose the NetBSD panic that is caused by
>>>> mainline QEMU (mentioned above).
>>>>
>>>> I have actually run the tests you requested (Hervé described them in an
>>>> earlier thread). There was no regression. Quite the reverse -- it's no
>>>> longer possible to remotely crash the NetBSD kernel.
>>>>
>>>> Apparently my testing was also the first time that the jazzsonic driver
>>>> (from the Linux/mips Magnum port) was tested successfully with QEMU. It
>>>> doesn't work in mainline QEMU.
>>>>
>>>
>>> Well, I appologize if I missed all these facts. I just did not notice
>> them, at least not in this form. And, yes, some "Tested-by:" by Herve
>> would be desirable and nice.
FWIW I tested Finn kernel and QEMU part following:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg667432.html
to check than its series doesn't introduce regressions, booting Linux
and NetBSD.
I haven't run the thorough networking tests Laurent do with the q800
(scp of big files, fetch over http in loop).
Hervé testing is welcomed, but as a hobbyist he doesn't spend more than
1h every 2 months on this, so I don't think his approval is a blocker.
We are not talking about business critical emulation, so we can fix
regressions on top.
--
That said, I'm spending some hobby time on a Magnum boot code to be able
to test the board upstream (without depending on proprietary BIOS and
painful graphical setup).
Currently I get NetBSD to kdb and Linux get stuck there:
https://paste.debian.net/plain/1129965
>>>
>>
>> Or, perhaps, even "Reviewed-by:".
>>
>
> It would be nice to have this merged before next release because q800
> machine networking is not reliable without them.
>
> And thank you to Finn for all his hard work on this device emulation.
>
> Laurent
>
next prev parent reply other threads:[~2020-02-19 8:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 9:27 [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation Finn Thain
2020-01-29 9:27 ` [PATCH v4 04/14] dp8393x: Have dp8393x_receive() return the packet size Finn Thain
2020-01-29 9:27 ` [PATCH v4 14/14] dp8393x: Don't stop reception upon RBE interrupt assertion Finn Thain
2020-01-29 9:27 ` [PATCH v4 01/14] dp8393x: Mask EOL bit from descriptor addresses Finn Thain
2020-01-29 9:27 ` [PATCH v4 06/14] dp8393x: Clear RRRA command register bit only when appropriate Finn Thain
2020-01-29 9:27 ` [PATCH v4 03/14] dp8393x: Clean up endianness hacks Finn Thain
2020-01-29 9:27 ` [PATCH v4 05/14] dp8393x: Update LLFA and CRDA registers from rx descriptor Finn Thain
2020-01-29 16:38 ` Philippe Mathieu-Daudé
2020-01-29 9:27 ` [PATCH v4 07/14] dp8393x: Implement packet size limit and RBAE interrupt Finn Thain
2020-01-29 9:27 ` [PATCH v4 09/14] dp8393x: Use long-word-aligned RRA pointers in 32-bit mode Finn Thain
2020-01-29 9:27 ` [PATCH v4 02/14] dp8393x: Always use 32-bit accesses Finn Thain
2020-01-29 9:27 ` [PATCH v4 10/14] dp8393x: Pad frames to word or long word boundary Finn Thain
2020-01-29 9:27 ` [PATCH v4 12/14] dp8393x: Always update RRA pointers and sequence numbers Finn Thain
2020-01-29 9:27 ` [PATCH v4 08/14] dp8393x: Don't clobber packet checksum Finn Thain
2020-01-29 9:27 ` [PATCH v4 11/14] dp8393x: Clear descriptor in_use field to release packet Finn Thain
2020-01-29 9:27 ` [PATCH v4 13/14] dp8393x: Don't reset Silicon Revision register Finn Thain
2020-01-29 16:37 ` Philippe Mathieu-Daudé
2020-02-04 3:58 ` [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation Jason Wang
2020-02-18 18:30 ` Aleksandar Markovic
2020-02-19 3:13 ` Jason Wang
2020-02-18 18:25 ` Aleksandar Markovic
2020-02-19 1:06 ` Finn Thain
2020-02-19 1:54 ` Aleksandar Markovic
2020-02-19 1:57 ` Aleksandar Markovic
2020-02-19 7:55 ` Laurent Vivier
2020-02-19 8:27 ` Philippe Mathieu-Daudé [this message]
2020-02-20 6:55 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=785abd9e-a02d-7850-ddfd-b8bc0fa146cd@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.m.mail@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=fthain@telegraphics.com.au \
--cc=hpoussin@reactos.org \
--cc=jasowang@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).