From: Si-Wei Liu <si-wei.liu@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Eugenio Perez Martin <eperezma@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"Zhu, Lingshan" <lingshan.zhu@intel.com>,
qemu-devel@nongnu.org, Liuxiangdong <liuxiangdong5@huawei.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
alvaro.karsz@solid-run.com, Shannon Nelson <snelson@pensando.io>,
Laurent Vivier <lvivier@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
Gautam Dawar <gdawar@xilinx.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Cornelia Huck <cohuck@redhat.com>, Cindy Lu <lulu@redhat.com>,
Eli Cohen <eli@mellanox.com>, Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Parav Pandit <parav@mellanox.com>
Subject: Re: [RFC v2 12/13] vdpa: preemptive kick at enable
Date: Sun, 5 Feb 2023 21:08:43 -0800 [thread overview]
Message-ID: <78695d89-287b-aac8-9c6c-b4ef31759a27@oracle.com> (raw)
In-Reply-To: <20230205045833-mutt-send-email-mst@kernel.org>
On 2/5/2023 2:00 AM, Michael S. Tsirkin wrote:
> On Sat, Feb 04, 2023 at 03:04:02AM -0800, Si-Wei Liu wrote:
>> For network hardware device, I thought suspend
>> just needs to wait until the completion of ongoing Tx/Rx DMA transaction
>> already in the flight, rather than to drain all the upcoming packets until
>> avail_idx.
> It depends I guess but if device expects to recover all state from just
> ring state in memory then at least it has to drain until some index
> value.
Yes, that's the general requirement for other devices than networking
device. For e.g., if a storage device had posted request before
suspending and there's no way to replay those requests from destination,
it needs to drain until all posted requests are completed. For network
device, this requirement can be lifted up somehow, as network (Ethernet)
usually is tolerant to packet drops. Jason and I once had a long
discussion about the expectation for {get,set}_vq_state() driver API and
we came to conclusion that this is something networking device can stand
up to:
https://lore.kernel.org/lkml/b2d18964-8cd6-6bb1-1995-5b966207046d@redhat.com/
-Siwei
next prev parent reply other threads:[~2023-02-06 5:10 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 17:24 [RFC v2 00/13] Dinamycally switch to vhost shadow virtqueues at vdpa net migration Eugenio Pérez
2023-01-12 17:24 ` [RFC v2 01/13] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check Eugenio Pérez
2023-01-13 3:12 ` Jason Wang
2023-01-13 6:42 ` Eugenio Perez Martin
2023-01-16 3:01 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 02/13] vdpa net: move iova tree creation from init to start Eugenio Pérez
2023-01-13 3:53 ` Jason Wang
2023-01-13 7:28 ` Eugenio Perez Martin
2023-01-16 3:05 ` Jason Wang
2023-01-16 9:14 ` Eugenio Perez Martin
2023-01-17 4:30 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 03/13] vdpa: copy cvq shadow_data from data vqs, not from x-svq Eugenio Pérez
2023-01-12 17:24 ` [RFC v2 04/13] vdpa: rewind at get_base, not set_base Eugenio Pérez
2023-01-13 4:09 ` Jason Wang
2023-01-13 7:40 ` Eugenio Perez Martin
2023-01-16 3:32 ` Jason Wang
2023-01-16 9:53 ` Eugenio Perez Martin
2023-01-17 4:38 ` Jason Wang
2023-01-17 6:57 ` Eugenio Perez Martin
2023-01-12 17:24 ` [RFC v2 05/13] vdpa net: add migration blocker if cannot migrate cvq Eugenio Pérez
2023-01-13 4:24 ` Jason Wang
2023-01-13 7:46 ` Eugenio Perez Martin
2023-01-16 3:34 ` Jason Wang
2023-01-16 5:23 ` Michael S. Tsirkin
2023-01-16 9:33 ` Eugenio Perez Martin
2023-01-17 5:42 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 06/13] vhost: delay set_vring_ready after DRIVER_OK Eugenio Pérez
2023-01-13 4:36 ` Jason Wang
2023-01-13 8:19 ` Eugenio Perez Martin
2023-01-13 9:51 ` Stefano Garzarella
2023-01-13 10:03 ` Eugenio Perez Martin
2023-01-13 10:37 ` Stefano Garzarella
2023-01-17 15:15 ` Maxime Coquelin
2023-01-16 6:36 ` Jason Wang
2023-01-16 16:16 ` Eugenio Perez Martin
2023-01-17 5:36 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 07/13] vdpa: " Eugenio Pérez
2023-01-12 17:24 ` [RFC v2 08/13] vdpa: Negotiate _F_SUSPEND feature Eugenio Pérez
2023-01-13 4:39 ` Jason Wang
2023-01-13 8:45 ` Eugenio Perez Martin
2023-01-16 6:48 ` Jason Wang
2023-01-16 16:17 ` Eugenio Perez Martin
2023-01-12 17:24 ` [RFC v2 09/13] vdpa: add feature_log parameter to vhost_vdpa Eugenio Pérez
2023-01-12 17:24 ` [RFC v2 10/13] vdpa net: allow VHOST_F_LOG_ALL Eugenio Pérez
2023-01-13 4:42 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 11/13] vdpa: add vdpa net migration state notifier Eugenio Pérez
2023-01-13 4:54 ` Jason Wang
2023-01-13 9:00 ` Eugenio Perez Martin
2023-01-16 6:51 ` Jason Wang
2023-01-16 15:21 ` Eugenio Perez Martin
2023-01-17 9:58 ` Dr. David Alan Gilbert
2023-01-17 10:23 ` Eugenio Perez Martin
2023-01-17 12:54 ` Dr. David Alan Gilbert
2023-02-02 1:52 ` Si-Wei Liu
2023-02-02 15:28 ` Eugenio Perez Martin
2023-02-04 2:03 ` Si-Wei Liu
2023-02-13 9:47 ` Eugenio Perez Martin
2023-02-13 22:36 ` Si-Wei Liu
2023-02-14 18:51 ` Eugenio Perez Martin
2023-02-12 14:31 ` Eli Cohen
2023-01-12 17:24 ` [RFC v2 12/13] vdpa: preemptive kick at enable Eugenio Pérez
2023-01-13 2:31 ` Jason Wang
2023-01-13 3:25 ` Zhu, Lingshan
2023-01-13 3:39 ` Jason Wang
2023-01-13 9:06 ` Eugenio Perez Martin
2023-01-16 7:02 ` Jason Wang
2023-02-02 16:55 ` Eugenio Perez Martin
2023-02-02 0:56 ` Si-Wei Liu
2023-02-02 16:53 ` Eugenio Perez Martin
2023-02-04 11:04 ` Si-Wei Liu
2023-02-05 10:00 ` Michael S. Tsirkin
2023-02-06 5:08 ` Si-Wei Liu [this message]
2023-01-12 17:24 ` [RFC v2 13/13] vdpa: Conditionally expose _F_LOG in vhost_net devices Eugenio Pérez
2023-02-02 1:00 ` [RFC v2 00/13] Dinamycally switch to vhost shadow virtqueues at vdpa net migration Si-Wei Liu
2023-02-02 11:27 ` Eugenio Perez Martin
2023-02-03 5:08 ` Si-Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78695d89-287b-aac8-9c6c-b4ef31759a27@oracle.com \
--to=si-wei.liu@oracle.com \
--cc=alvaro.karsz@solid-run.com \
--cc=arei.gonglei@huawei.com \
--cc=cohuck@redhat.com \
--cc=eli@mellanox.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=liuxiangdong5@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=snelson@pensando.io \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).