From: Richard Henderson <richard.henderson@linaro.org>
To: "Víctor Colombo" <victor.colombo@eldorado.org.br>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: clg@kaod.org, danielhb413@gmail.com, david@gibson.dropbear.id.au,
groug@kaod.org, balaton@eik.bme.hu
Subject: Re: [PATCH v2 16/21] target/ppc: Remove msr_ep macro
Date: Mon, 2 May 2022 14:50:02 -0700 [thread overview]
Message-ID: <786af1fb-0484-6901-6905-13b346b77a6b@linaro.org> (raw)
In-Reply-To: <20220502143934.71908-17-victor.colombo@eldorado.org.br>
On 5/2/22 07:39, Víctor Colombo wrote:
> - if (unlikely((value >> MSR_EP) & 1) != msr_ep) {
> - env->excp_prefix = ((value >> MSR_EP) & 1) * 0xFFF00000;
> + if (unlikely(!(value & env->msr & R_MSR_EP_MASK))) {
Needs xor.
> + env->excp_prefix = FIELD_EX64(env->msr, MSR, EP) * 0xFFF00000;
Needs extract from value.
r~
next prev parent reply other threads:[~2022-05-02 21:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 14:39 [PATCH v2 00/21] target/ppc: Remove hidden usages of *env Víctor Colombo
2022-05-02 14:39 ` [PATCH v2 01/21] target/ppc: Remove fpscr_* macros from cpu.h Víctor Colombo
2022-05-02 14:39 ` [PATCH v2 02/21] target/ppc: Remove unused msr_* macros Víctor Colombo
2022-05-02 14:39 ` [PATCH v2 03/21] target/ppc: Remove msr_pr macro Víctor Colombo
2022-05-02 21:57 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 04/21] target/ppc: Remove msr_le macro Víctor Colombo
2022-05-02 21:57 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 05/21] target/ppc: Remove msr_ds macro Víctor Colombo
2022-05-02 21:57 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 06/21] target/ppc: Remove msr_ile macro Víctor Colombo
2022-05-02 21:58 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 07/21] target/ppc: Remove msr_ee macro Víctor Colombo
2022-05-02 21:58 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 08/21] target/ppc: Remove msr_ce macro Víctor Colombo
2022-05-02 21:58 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 09/21] target/ppc: Remove msr_pow macro Víctor Colombo
2022-05-02 21:58 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 10/21] target/ppc: Remove msr_me macro Víctor Colombo
2022-05-02 21:58 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 11/21] target/ppc: Remove msr_gs macro Víctor Colombo
2022-05-02 21:44 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 12/21] target/ppc: Remove msr_fp macro Víctor Colombo
2022-05-02 21:58 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 13/21] target/ppc: Remove msr_me macro Víctor Colombo
2022-05-02 21:38 ` Richard Henderson
2022-05-02 21:59 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 14/21] target/ppc: Remove msr_ir macro Víctor Colombo
2022-05-02 21:45 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 15/21] target/ppc: Remove msr_dr macro Víctor Colombo
2022-05-02 21:47 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 16/21] target/ppc: Remove msr_ep macro Víctor Colombo
2022-05-02 21:50 ` Richard Henderson [this message]
2022-05-02 14:39 ` [PATCH v2 17/21] target/ppc: Remove msr_fe0 and msr_fe1 macros Víctor Colombo
2022-05-02 22:00 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 18/21] target/ppc: Remove msr_ts macro Víctor Colombo
2022-05-02 22:01 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 19/21] target/ppc: Remove msr_hv macro Víctor Colombo
2022-05-02 21:55 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 20/21] target/ppc: Add unused msr bits FIELDs Víctor Colombo
2022-05-02 22:01 ` Richard Henderson
2022-05-02 14:39 ` [PATCH v2 21/21] target/ppc: Change MSR_* to follow POWER ISA numbering convention Víctor Colombo
2022-05-02 14:59 ` [PATCH v2 00/21] target/ppc: Remove hidden usages of *env Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=786af1fb-0484-6901-6905-13b346b77a6b@linaro.org \
--to=richard.henderson@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=victor.colombo@eldorado.org.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).