From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61F24C433EF for ; Mon, 2 May 2022 21:51:13 +0000 (UTC) Received: from localhost ([::1]:53676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nldwm-0002io-Fx for qemu-devel@archiver.kernel.org; Mon, 02 May 2022 17:51:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nldvk-0001mp-AI for qemu-devel@nongnu.org; Mon, 02 May 2022 17:50:08 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:38653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nldvi-0004Mi-41 for qemu-devel@nongnu.org; Mon, 02 May 2022 17:50:08 -0400 Received: by mail-pg1-x52d.google.com with SMTP id e5so1547074pgc.5 for ; Mon, 02 May 2022 14:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zA0Ta0L3eeEY8+LlOAHSwc3GMl8kOUZos5ExwCAufLA=; b=MX3CdLAGD3YYW/dlZudXjn28BqmAUYd5J2EqEZNXY1j0MZhhdjioKz/NX4hOoP2Gar kebGkbYv+bAoTas8TnbAQ+MTuS4oCzla6LkqGc/M6xi3wISMrTuoxTFQFwgomwXhkRC0 XQWv5tfTVOgE1dNUm0wHXkxbqqSdgMnwrAC4Y21yplTz4yLtKvxu9r5RZNkOwlJLSQTc rpPBoyV+mYc0+QI4AP51heSgfZWq9225CuqxgmDrkhZ/dl3Iu2OBeN+aztSeDeqe4N/f AQpNgmlxxe/Ay+yUqaHVyfT7iap/1qDGZWGZm5v7ZUOUZBEiMY/clDtgVOs/jHdHMG9T z+IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zA0Ta0L3eeEY8+LlOAHSwc3GMl8kOUZos5ExwCAufLA=; b=YgNtCtIz1Ofz8R2eWk27OSSjzt7Mz7p+HH4VV1nRk0mtp8C5odFbEDW0++LTWGhXbg AsukxQS6yD53dJCJbmEibQ9d/ilyaNR315qTU7geGQ55waTgtDPPSubC5itr1VYu3Pm+ euCzyZpPV6Nip110iH/t9Z/9BuBginE4xoa/YtdKYlz0mFtDijQ+t8xlqO0hSV1roc9B xQSlm50Phbp75ns/bWWIRvflrCxMFwRwGx3r0cke18h5ZLGV6Wk5Y7OqAhuga2r4+fDL qZB71PmsZkgR10Djui50fxIc+DBJ4O3+chEWgWCVmndvAlSWWa/yT/3QmqZjD/gwAhi1 08cg== X-Gm-Message-State: AOAM532RFQG++1MtBOQb1uHagXZECnnwRSnHmGAe4gCQ1vLFpaat09kp jR053Urbaruf9+FRUSrf+sbHqg== X-Google-Smtp-Source: ABdhPJxsx8Ux+SMdjmUvs1KvpMbnO147q9SYFSRskEAnzjMaX1Ro7kAe3YczG6D9C3tgI5Gs1yQLWA== X-Received: by 2002:a05:6a00:212c:b0:50d:a337:7437 with SMTP id n12-20020a056a00212c00b0050da3377437mr13272477pfj.70.1651528204420; Mon, 02 May 2022 14:50:04 -0700 (PDT) Received: from [192.168.1.6] ([71.212.142.129]) by smtp.gmail.com with ESMTPSA id q21-20020a62ae15000000b0050dc76281e2sm5131400pff.188.2022.05.02.14.50.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 14:50:04 -0700 (PDT) Message-ID: <786af1fb-0484-6901-6905-13b346b77a6b@linaro.org> Date: Mon, 2 May 2022 14:50:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 16/21] target/ppc: Remove msr_ep macro Content-Language: en-US To: =?UTF-8?Q?V=c3=adctor_Colombo?= , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: clg@kaod.org, danielhb413@gmail.com, david@gibson.dropbear.id.au, groug@kaod.org, balaton@eik.bme.hu References: <20220502143934.71908-1-victor.colombo@eldorado.org.br> <20220502143934.71908-17-victor.colombo@eldorado.org.br> From: Richard Henderson In-Reply-To: <20220502143934.71908-17-victor.colombo@eldorado.org.br> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/2/22 07:39, Víctor Colombo wrote: > - if (unlikely((value >> MSR_EP) & 1) != msr_ep) { > - env->excp_prefix = ((value >> MSR_EP) & 1) * 0xFFF00000; > + if (unlikely(!(value & env->msr & R_MSR_EP_MASK))) { Needs xor. > + env->excp_prefix = FIELD_EX64(env->msr, MSR, EP) * 0xFFF00000; Needs extract from value. r~