From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] hw/arm: Move raspberrypi-fw-defs.h to the include/hw/arm/ folder
Date: Thu, 12 Oct 2023 10:22:50 +0200 [thread overview]
Message-ID: <788f54e1-3f2f-f24d-63cf-172efc605823@linaro.org> (raw)
In-Reply-To: <20231012073458.860187-1-thuth@redhat.com>
On 12/10/23 09:34, Thomas Huth wrote:
> The file is obviously related to the raspberrypi machine, so
> it should reside in hw/arm/ instead of hw/misc/.
Not quite. These are the VideoCore DSP definitions. Firmware
running on SoC including a VC can use this syscall-like interface.
FWIW there are a pair of QEMU VC implementations on GitHub.
Anyhow, preferably rewording the description,
Acked-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> And while we're
> at it, also adjust the wildcard in MAINTAINERS so that it covers
> this file, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> MAINTAINERS | 2 +-
> include/hw/{misc => arm}/raspberrypi-fw-defs.h | 0
> hw/misc/bcm2835_property.c | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename include/hw/{misc => arm}/raspberrypi-fw-defs.h (100%)
next prev parent reply other threads:[~2023-10-12 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 7:34 [PATCH] hw/arm: Move raspberrypi-fw-defs.h to the include/hw/arm/ folder Thomas Huth
2023-10-12 7:54 ` Alex Bennée
2023-10-12 8:22 ` Philippe Mathieu-Daudé [this message]
2023-10-12 10:55 ` Thomas Huth
2023-10-16 16:26 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=788f54e1-3f2f-f24d-63cf-172efc605823@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).