From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18D8EC77B7C for ; Wed, 31 May 2023 05:58:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4Epw-0004JF-7S; Wed, 31 May 2023 01:57:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Epe-0004DY-Q3; Wed, 31 May 2023 01:57:15 -0400 Received: from 3.mo548.mail-out.ovh.net ([188.165.32.156]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4EpX-0003lH-G7; Wed, 31 May 2023 01:57:09 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.146.173]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 566FA205FC; Wed, 31 May 2023 05:57:02 +0000 (UTC) Received: from kaod.org (37.59.142.106) by DAG8EX2.mxp5.local (172.16.2.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 31 May 2023 07:57:01 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-106R006ef32e9b2-4197-4da8-9ab0-68f1a643ffbe, AD4A5C7A17A66D4AFB6DE796C11E1CF112258E66) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <78953a5f-9a18-d718-c86c-2e6884e630ef@kaod.org> Date: Wed, 31 May 2023 07:57:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 03/12] aspeed: Use the boot_rom region of the fby35 machine Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , CC: , Peter Maydell , Joel Stanley , Andrew Jeffery , Peter Delevoryas References: <20230508075859.3326566-1-clg@kaod.org> <20230508075859.3326566-4-clg@kaod.org> <981dd9cc-9d2a-9e41-8ae9-4fa355b0b061@linaro.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <981dd9cc-9d2a-9e41-8ae9-4fa355b0b061@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.106] X-ClientProxiedBy: DAG4EX2.mxp5.local (172.16.2.32) To DAG8EX2.mxp5.local (172.16.2.72) X-Ovh-Tracer-GUID: 849bd6c1-9202-4803-bd4a-a68ee4885f91 X-Ovh-Tracer-Id: 16261935306249309033 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrfeekkedguddtfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitgcunfgvucfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepffdufeeliedujeeffffhjeffiefghffhhfdvkeeijeehledvueffhfejtdehgeegnecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutdeipdekvddrieegrddvhedtrddujedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeotghlgheskhgrohgurdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehphhhilhhmugeslhhinhgrrhhordhorhhgpdhqvghmuhdqrghrmhesnhhonhhgnhhurdhorhhgpdhqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgpdhpvghtvghrrdhmrgihuggvlhhlsehlihhnrghrohdrohhrghdpjhhovghlsehjmhhsrdhiugdrrghupdgrnhgurhgvfiesrghjrdhiugdrrghupdhpvghtvghrsehpjhgurdguvghvpdfovfetjfhoshhtpehmohehgeekpdhmohguvgepshhmthhpohhuth Received-SPF: pass client-ip=188.165.32.156; envelope-from=clg@kaod.org; helo=3.mo548.mail-out.ovh.net X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 5/30/23 23:27, Philippe Mathieu-Daudé wrote: > On 8/5/23 09:58, Cédric Le Goater wrote: >> This change completes commits 5aa281d757 ("aspeed: Introduce a >> spi_boot region under the SoC") and 8b744a6a47 ("aspeed: Add a >> boot_rom overlap region in the SoC spi_boot container") which >> introduced a spi_boot container at the SoC level to map the boot rom >> region as an overlap. > > 2nd patch, > >> It also fixes a Coverity report (CID 1508061) for a memory leak >> warning when the QEMU process exits by using an bmc_boot_rom >> MemoryRegion available at the machine level. > > 1st patch? That would be superfluous. > >> Cc: Peter Delevoryas >> Signed-off-by: Cédric Le Goater >> --- >>   hw/arm/fby35.c | 29 +++++++++++++++-------------- >>   1 file changed, 15 insertions(+), 14 deletions(-) >