Re: [PATCH] ui/vdagent: fix windows agent regression

[Fiona Ebner <f.ebner@proxmox.com>]

Am 27.10.25 um 2:09 PM schrieb marcandre.lureau@redhat.com:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Since commit f626116f ("ui/vdagent: factor out clipboard peer
> registration"), the QEMU clipboard serial is reset whenever the vdagent
> chardev receives the guest caps. This triggers a CHR_EVENT_CLOSED which
> is handled by virtio_serial_close() to notify the guest.
> 
> The "reconnection logic" is there to reset the agent when a
> client (dbus, spice etc) reconnects, or the agent is restarted.
> It is required to sync the clipboard serials and to prevent races or
> loops due to clipboard managers on both ends (but this is not
> implemented by windows vdagent).
> 
> The Unix agent has been reconnecting without resending caps, thus
> working with this approach.
> 
> However, the Windows agent does not seem to have a way to handle
> VIRTIO_CONSOLE_PORT_OPEN=0 event and do not receive further data...
> 
> Let's not trigger this disconnection/reset logic if the agent does not
> support VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL.
> 
> Fixes: f626116f ("ui/vdagent: factor out clipboard peer registration")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reported-by: Lucas Kornicki <lucas.kornicki@nutanix.com>

Thank you for the fix!

Tested-by: Fiona Ebner <f.ebner@proxmox.com>

and with my very limited knowledge in the area:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

CC: qemu-stable, because it affects 10.1