From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, kraxel@redhat.com
Subject: Re: [PATCH 3/3] vnc: support "-vnc help"
Date: Wed, 20 Jan 2021 09:44:06 -0600 [thread overview]
Message-ID: <78bcf36d-1f72-44e6-0efc-5b6b92076187@redhat.com> (raw)
In-Reply-To: <20210120144235.345983-4-pbonzini@redhat.com>
On 1/20/21 8:42 AM, Paolo Bonzini wrote:
> Use qemu_opts_parse_noisily now that HMP does not call
> vnc_parse anymore.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> include/ui/console.h | 2 +-
> softmmu/vl.c | 6 +++---
> ui/vnc-stubs.c | 7 +++----
> ui/vnc.c | 8 ++++----
> 4 files changed, 11 insertions(+), 12 deletions(-)
Unless something about my comments on 2/3 causes us to change,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-01-20 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 14:42 [PATCH 0/3] vnc: remove "change vnc TARGET" and QMP change command, support "-vnc help" Paolo Bonzini
2021-01-20 14:42 ` [PATCH 1/3] hmp: remove "change vnc TARGET" command Paolo Bonzini
2021-01-20 15:24 ` Eric Blake
2021-01-20 14:42 ` [PATCH 2/3] qmp: remove deprecated "change" command Paolo Bonzini
2021-01-20 15:21 ` Philippe Mathieu-Daudé
2021-01-20 15:31 ` Eric Blake
2021-01-20 14:42 ` [PATCH 3/3] vnc: support "-vnc help" Paolo Bonzini
2021-01-20 15:44 ` Eric Blake [this message]
2021-01-21 10:38 ` [PATCH 0/3] vnc: remove "change vnc TARGET" and QMP change command, " Gerd Hoffmann
2021-01-21 10:52 ` Daniel P. Berrangé
2021-01-21 11:13 ` Gerd Hoffmann
2021-01-21 12:02 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78bcf36d-1f72-44e6-0efc-5b6b92076187@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).