From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower
Date: Thu, 31 May 2018 11:38:24 -0400 [thread overview]
Message-ID: <78d5dcf5-1694-08d3-c47c-4dbc85501a24@redhat.com> (raw)
In-Reply-To: <e394c9c5-e65e-5df5-71b3-5cdf87016be3@redhat.com>
On 05/31/2018 10:56 AM, Eric Blake wrote:
> On 05/30/2018 07:43 PM, John Snow wrote:
>> These functions work on the AHCI device, not the individual
>
> s/device/state/ ?
>
It's confusing; the AHCI device itself (the HBA) is represented by the
struct AHCIState. the SATA devices are referred to by "AHCIDevice".
Not great names, admittedly.
--js
>> AHCI devices, so trim the AHCIDevice argument.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> hw/ide/ahci.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>
next prev parent reply other threads:[~2018-05-31 15:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 0:43 [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition John Snow
2018-05-31 0:43 ` [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower John Snow
2018-05-31 14:56 ` Eric Blake
2018-05-31 15:38 ` John Snow [this message]
2018-05-31 16:00 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-31 0:43 ` [Qemu-devel] [PATCH 2/3] ahci: fix PxCI register race John Snow
2018-05-31 16:16 ` John Snow
2018-05-31 16:22 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-31 0:43 ` [Qemu-devel] [PATCH 3/3] ahci: don't schedule unnecessary BH John Snow
2018-05-31 16:22 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-31 8:01 ` [Qemu-devel] [Qemu-block] [PATCH 0/3] ahci: fix completion race condition Stefan Hajnoczi
2018-05-31 12:21 ` [Qemu-devel] " Bruce Rogers
2018-05-31 13:06 ` Philippe Mathieu-Daudé
2018-05-31 13:12 ` Bruce Rogers
2018-06-01 0:00 ` John Snow
2018-06-04 9:22 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d5dcf5-1694-08d3-c47c-4dbc85501a24@redhat.com \
--to=jsnow@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).