qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts
Date: Thu, 18 Apr 2019 17:26:54 +0200	[thread overview]
Message-ID: <78da03ed-2b9f-2357-6f28-44115d8b2955@redhat.com> (raw)
In-Reply-To: <20190418145355.21100-4-armbru@redhat.com>

On 4/18/19 4:53 PM, Markus Armbruster wrote:
> "Debugging with GDB / Appendix E GDB Remote Serial Protocol /
> Overview" specifies "The printable characters '#' and '$' or with a
> numeric value greater than 126 must not be used."  gdb_read_byte()
> only rejects values < 32.  This is wrong.  Impact depends on the caller:
> 
> * gdb_handlesig() passes a char.  Incorrectly accepts '#', '$' and
>   '\127'.
> 
> * gdb_chr_receive() passes an uint8_t.  Additionally accepts
>   characters with the most-significant bit set.
> 
> Correct the validity check to match the specification.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  gdbstub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index d54abd17cc..a6dce1b027 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2064,7 +2064,7 @@ static void gdb_read_byte(GDBState *s, int ch)
>              }
>              break;
>          case RS_GETLINE_RLE:
> -            if (ch < ' ') {

Can you add a comment referring to the ""Debugging with GDB / Appendix E
GDB Remote Serial Protocol / Overview" here?

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> +            if (ch < ' ' || ch == '#' || ch == '$' || ch > 126) {
>                  /* invalid RLE count encoding */
>                  trace_gdbstub_err_invalid_repeat((uint8_t)ch);
>                  s->state = RS_GETLINE;
> 

  parent reply	other threads:[~2019-04-18 15:35 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 14:53 [Qemu-devel] [PATCH 0/6] Fix misuse of ctype.h functions Markus Armbruster
2019-04-18 14:53 ` Markus Armbruster
2019-04-18 14:53 ` [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace() Markus Armbruster
2019-04-18 14:53   ` Markus Armbruster
2019-04-18 15:19   ` Philippe Mathieu-Daudé
2019-04-18 15:19     ` Philippe Mathieu-Daudé
2019-05-13 13:13     ` Markus Armbruster
2019-05-13 13:58       ` Peter Maydell
2019-05-14 12:18         ` Markus Armbruster
2019-05-14 16:03           ` Philippe Mathieu-Daudé
2019-05-15  4:04           ` Jason Wang
2019-05-15  6:34             ` Markus Armbruster
2019-05-15 10:09               ` Peter Maydell
2019-05-15 10:26               ` Daniel P. Berrangé
2019-05-15 14:54                 ` Markus Armbruster
2019-05-15 14:55                   ` Daniel P. Berrangé
2019-05-15 15:38                   ` Richard Henderson
2019-05-15 16:55                   ` Markus Armbruster
2019-05-15 17:28                     ` Richard Henderson
2019-05-15 13:35               ` Paolo Bonzini
2019-05-17  4:35                 ` Jason Wang
2019-05-17 11:45                   ` Paolo Bonzini
2019-04-18 14:53 ` [Qemu-devel] [PATCH 2/6] tests/vhost-user-bridge: Fix misuse of isdigit() Markus Armbruster
2019-04-18 14:53   ` Markus Armbruster
2019-04-18 14:53 ` [Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts Markus Armbruster
2019-04-18 14:53   ` Markus Armbruster
2019-04-18 15:26   ` Philippe Mathieu-Daudé [this message]
2019-04-18 15:26     ` Philippe Mathieu-Daudé
2019-05-13 12:39     ` Markus Armbruster
2019-05-13 13:05       ` Philippe Mathieu-Daudé
2019-04-18 14:53 ` [Qemu-devel] [PATCH 4/6] gdbstub: Fix misuse of isxdigit() Markus Armbruster
2019-04-18 14:53   ` Markus Armbruster
2019-04-18 14:53 ` [Qemu-devel] [PATCH 5/6] pc-bios/s390-ccw: Clean up harmless misuse of isdigit() Markus Armbruster
2019-04-18 14:53   ` Markus Armbruster
2019-04-18 16:28   ` Thomas Huth
2019-04-18 16:28     ` Thomas Huth
2019-04-18 18:13     ` Markus Armbruster
2019-04-18 18:13       ` Markus Armbruster
2019-05-08  8:51       ` Thomas Huth
2019-04-18 14:53 ` [Qemu-devel] [PATCH 6/6] cutils: Simplify how parse_uint() checks for whitespace Markus Armbruster
2019-04-18 14:53   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78da03ed-2b9f-2357-6f28-44115d8b2955@redhat.com \
    --to=philmd@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).