From: Joao Martins <joao.m.martins@oracle.com>
To: Anthony Krowiak <akrowiak@linux.ibm.com>,
Zhenzhong Duan <zhenzhong.duan@intel.com>,
qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, clg@redhat.com,
eric.auger@redhat.com, chao.p.peng@intel.com,
Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
"open list:S390 general arch..." <qemu-s390x@nongnu.org>
Subject: Re: [PATCH 1/2] vfio/ap: Don't initialize HOST_IOMMU_DEVICE with mdev
Date: Mon, 22 Jul 2024 16:52:26 +0100 [thread overview]
Message-ID: <78def100-c088-4d87-bd9e-d7c87d054cf8@oracle.com> (raw)
In-Reply-To: <aeb1fd39-6a2f-4bab-8cce-84d3b113a667@linux.ibm.com>
On 22/07/2024 16:46, Anthony Krowiak wrote:
>
> On 7/22/24 5:18 AM, Joao Martins wrote:
>> On 22/07/2024 08:07, Zhenzhong Duan wrote:
>>> mdevs aren't "physical" devices and when asking for backing IOMMU info,
>>> it fails the entire provisioning of the guest. Fix that by setting
>>> vbasedev->mdev true so skipping HostIOMMUDevice initialization in the
>>> presence of mdevs.
>>>
>>> Fixes: 930589520128 ("vfio/iommufd: Implement HostIOMMUDeviceClass::realize()
>>> handler")
>>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
>
>
> I'm at a bit of a loss here. We've been starting guests with AP devices being
> passed through using VFIO for years. Did the fix for
>
> 930589520128 precipitate this?
Yes. The fix commit ids introduced this and it was not intended. Also the
failure, again, is only reproduceable with IOMMUFD and it doesn't apply for
type1-iommu that you are likely using. Both are different IOMMU backends.
Joao
next prev parent reply other threads:[~2024-07-22 15:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 7:07 [PATCH 0/2] Don't initialize HOST_IOMMU_DEVICE with mdev Zhenzhong Duan
2024-07-22 7:07 ` [PATCH 1/2] vfio/ap: " Zhenzhong Duan
2024-07-22 9:18 ` Joao Martins
2024-07-22 15:46 ` Anthony Krowiak
2024-07-22 15:52 ` Joao Martins [this message]
2024-07-22 7:07 ` [PATCH 2/2] vfio/ccw: " Zhenzhong Duan
2024-07-22 9:18 ` Joao Martins
2024-07-22 14:57 ` Eric Farman
2024-07-22 15:09 ` Joao Martins
2024-07-22 15:36 ` Cédric Le Goater
2024-07-22 17:45 ` Eric Farman
2024-07-23 2:52 ` Duan, Zhenzhong
2024-07-22 9:31 ` [PATCH 0/2] " Eric Auger
2024-07-22 10:02 ` Cédric Le Goater
2024-07-22 13:50 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78def100-c088-4d87-bd9e-d7c87d054cf8@oracle.com \
--to=joao.m.martins@oracle.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jjherne@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).