qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com,
	armbru@redhat.com, mreitz@redhat.com
Subject: Re: [PATCH v6 1/3] block: introduce compress filter driver
Date: Mon, 11 Nov 2019 14:47:13 -0600	[thread overview]
Message-ID: <78fde14e-b573-f7e0-d211-f066c3767b7d@redhat.com> (raw)
In-Reply-To: <1573488277-794975-2-git-send-email-andrey.shinkevich@virtuozzo.com>

On 11/11/19 10:04 AM, Andrey Shinkevich wrote:
> Allow writing all the data compressed through the filter driver.
> The written data will be aligned by the cluster size.
> Based on the QEMU current implementation, that data can be written to
> unallocated clusters only. May be used for a backup job.
> 
> Suggested-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
>   block/Makefile.objs     |   1 +
>   block/filter-compress.c | 212 ++++++++++++++++++++++++++++++++++++++++++++++++
>   qapi/block-core.json    |  10 ++-
>   3 files changed, 219 insertions(+), 4 deletions(-)
>   create mode 100644 block/filter-compress.c

> +++ b/qapi/block-core.json
> @@ -2884,15 +2884,16 @@
>   # @copy-on-read: Since 3.0
>   # @blklogwrites: Since 3.0
>   # @blkreplay: Since 4.2
> +# @compress: Since 4.2

Are we still trying to get this in 4.2, even though soft freeze is past? 
  Or are we going to have to defer it to 5.0 as a new feature?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  reply	other threads:[~2019-11-11 20:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 16:04 [PATCH v6 0/3] qcow2: advanced compression options Andrey Shinkevich
2019-11-11 16:04 ` [PATCH v6 1/3] block: introduce compress filter driver Andrey Shinkevich
2019-11-11 20:47   ` Eric Blake [this message]
2019-11-12  8:57     ` Vladimir Sementsov-Ogievskiy
2019-11-12  9:39   ` Kevin Wolf
2019-11-12 10:07     ` Andrey Shinkevich
2019-11-12 10:24       ` Vladimir Sementsov-Ogievskiy
2019-11-12 10:33   ` Vladimir Sementsov-Ogievskiy
2019-11-11 16:04 ` [PATCH v6 2/3] qcow2: Allow writing compressed data of multiple clusters Andrey Shinkevich
2019-11-11 16:04 ` [PATCH v6 3/3] tests/qemu-iotests: add case to write " Andrey Shinkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78fde14e-b573-f7e0-d211-f066c3767b7d@redhat.com \
    --to=eblake@redhat.com \
    --cc=andrey.shinkevich@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).