From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@gmail.com, mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH v4 26/34] qapi: Mark deprecated QMP parts with feature 'deprecated'
Date: Tue, 17 Mar 2020 15:40:14 -0500 [thread overview]
Message-ID: <7903672f-2acf-bf9f-cadf-f5e0dc1abc43@redhat.com> (raw)
In-Reply-To: <20200317115459.31821-27-armbru@redhat.com>
On 3/17/20 6:54 AM, Markus Armbruster wrote:
> Add feature 'deprecated' to the deprecated QMP commands, so their
> deprecation becomes visible in output of query-qmp-schema. Looks like
> this:
>
> {"name": "query-cpus",
> "ret-type": "[164]",
> "meta-type": "command",
> "arg-type": "0",
> ---> "features": ["deprecated"]}
>
> Management applications could conceivably use this for static
> checking.
>
> The deprecated commands are change, cpu-add, migrate-set-cache-size,
> migrate_set_downtime, migrate_set_speed, query-cpus, query-events,
> query-migrate-cache-size.
>
> The deprecated command arguments are block-commit arguments @base and
> @top, and block_set_io_throttle, blockdev-change-medium,
> blockdev-close-tray, blockdev-open-tray, eject argument @device.
>
> The deprecated command results are query-cpus-fast result @arch,
> query-block result @dirty-bitmaps, query-named-block-nodes result
> @encryption_key_missing and result @dirty-bitmaps's member @status.
> Same for query-block result @inserted, which mirrors
> query-named-block-nodes.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-03-17 20:41 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 11:54 [PATCH v4 00/34] Configurable policy for handling deprecated interfaces Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 01/34] qemu-doc: Belatedly document QMP command arg & result deprecation Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 02/34] qapi: Belatedly update doc comment for @wait deprecation Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 03/34] docs/devel/qapi-code-gen: Clarify allow-oob introspection Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 04/34] docs/devel/qapi-code-gen: Document 'features' introspection Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 06/34] tests/test-qmp-cmds: Check responses more thoroughly Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 07/34] tests/test-qmp-cmds: Simplify test data setup Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 08/34] tests/test-qmp-event: " Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 09/34] tests/test-qmp-event: Use qobject_is_equal() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 10/34] tests/test-qmp-event: Check event is actually emitted Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 11/34] qapi/schema: Clean up around QAPISchemaEntity.connect_doc() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 12/34] qapi: Add feature flags to remaining definitions Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 13/34] qapi: Consistently put @features parameter right after @ifcond Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 14/34] qapi/introspect: Rename *qlit* to reduce confusion Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 15/34] qapi/introspect: Factor out _make_tree() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 16/34] qapi/schema: Change _make_features() to a take feature list Markus Armbruster
2020-03-17 20:22 ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 17/34] qapi/schema: Reorder classes so related ones are together Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 18/34] qapi/schema: Rename QAPISchemaObjectType{Variant, Variants} Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 19/34] qapi/schema: Call QAPIDoc.connect_member() in just one place Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 20/34] qapi: Add feature flags to struct members Markus Armbruster
2020-03-17 20:27 ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 21/34] qapi: Inline do_qmp_dispatch() into qmp_dispatch() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 22/34] qapi: Simplify how qmp_dispatch() deals with QCO_NO_SUCCESS_RESP Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 23/34] qapi: Simplify how qmp_dispatch() gets the request ID Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation Markus Armbruster
2020-03-17 20:29 ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 25/34] qapi: New special feature flag "deprecated" Markus Armbruster
2020-03-17 20:32 ` Eric Blake
2020-03-17 20:40 ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 26/34] qapi: Mark deprecated QMP parts with feature 'deprecated' Markus Armbruster
2020-03-17 20:40 ` Eric Blake [this message]
2020-03-17 11:54 ` [PATCH v4 27/34] qemu-options: New -compat to set policy for deprecated interfaces Markus Armbruster
2020-03-17 21:05 ` Eric Blake
2020-03-18 6:59 ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 28/34] qapi: Implement deprecated-output=hide for QMP command results Markus Armbruster
2020-03-18 10:40 ` Eric Blake
2020-03-18 16:47 ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 29/34] qapi: Implement deprecated-output=hide for QMP events Markus Armbruster
2020-03-18 12:29 ` Eric Blake
2020-03-18 16:59 ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 30/34] qapi: Implement deprecated-output=hide for QMP event data Markus Armbruster
2020-03-18 15:20 ` Eric Blake
2020-03-18 17:01 ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 31/34] qapi: Implement deprecated-output=hide for QMP introspection Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 32/34] qapi: Implement deprecated-input=reject for QMP commands Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 33/34] qapi: Implement deprecated-input=reject for QMP command arguments Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 34/34] qapi: New -compat deprecated-input=crash Markus Armbruster
2020-03-17 13:10 ` [PATCH v4 00/34] Configurable policy for handling deprecated interfaces Marc-André Lureau
2020-03-17 15:32 ` Markus Armbruster
2020-03-17 20:58 ` Markus Armbruster
2020-05-04 8:24 ` Peter Krempa
2020-05-08 13:01 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7903672f-2acf-bf9f-cadf-f5e0dc1abc43@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).