From: "haibinzhang(张海斌)" <haibinzhang@tencent.com>
To: Peter Maydell <peter.maydell@linaro.org>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [PATCH] hw/arm/virt: use pflash image real size when mapping
Date: Fri, 18 Sep 2020 12:26:30 +0000 [thread overview]
Message-ID: <790EEEF3-0799-4507-BF30-DA85440E766F@tencent.com> (raw)
Default size of arm-virt pflash image is 64MB which
will cost extra 128MB(64MBx2) memory per qemu process
and 12.5GB for 100 qemu processes. Host memory is
precious and it is valuable to reduce pflash image size.
For compatibility arm-virt uses real size when mapping.
Signed-off-by: Haibin Zhang <haibinzhang@tencent.com>
---
hw/arm/virt.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index acf9bfbece..3545e12865 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -50,6 +50,7 @@
#include "sysemu/sysemu.h"
#include "sysemu/tpm.h"
#include "sysemu/kvm.h"
+#include "sysemu/block-backend.h"
#include "hw/loader.h"
#include "exec/address-spaces.h"
#include "qemu/bitops.h"
@@ -1001,10 +1002,27 @@ static void virt_flash_map(VirtMachineState *vms,
*/
hwaddr flashsize = vms->memmap[VIRT_FLASH].size / 2;
hwaddr flashbase = vms->memmap[VIRT_FLASH].base;
+ int64_t realsize;
+ BlockBackend *blk;
- virt_flash_map1(vms->flash[0], flashbase, flashsize,
+ realsize = flashsize;
+ blk = pflash_cfi01_get_blk(vms->flash[0]);
+ if (blk) {
+ realsize = blk_getlength(blk);
+ realsize = realsize < flashsize ? realsize : flashsize;
+ }
+
+ virt_flash_map1(vms->flash[0], flashbase, realsize,
secure_sysmem);
- virt_flash_map1(vms->flash[1], flashbase + flashsize, flashsize,
+
+ realsize = flashsize;
+ blk = pflash_cfi01_get_blk(vms->flash[1]);
+ if (blk) {
+ realsize = blk_getlength(blk);
+ realsize = realsize < flashsize ? realsize : flashsize;
+ }
+
+ virt_flash_map1(vms->flash[1], flashbase + flashsize, realsize,
sysmem);
}
--
2.23.0
next reply other threads:[~2020-09-18 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 12:26 haibinzhang(张海斌) [this message]
2020-09-18 13:41 ` [PATCH] hw/arm/virt: use pflash image real size when mapping Philippe Mathieu-Daudé
2020-09-19 10:03 ` haibinzhang(张海斌)
2020-09-21 5:34 ` haibinzhang(张海斌)
2020-09-22 6:57 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2020-09-18 12:21 haibinzhang(张海斌)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=790EEEF3-0799-4507-BF30-DA85440E766F@tencent.com \
--to=haibinzhang@tencent.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).