Re: [Qemu-devel] [PATCH] Change name of live migration thread

[Pankaj Gupta <pagupta@redhat.com>]

Hi Dave,

> > Change the name of live migration thread from 'migration'
> > to 'qemu_vm_migration' to identify it clearly. 'migration'
> > is a generic word and kernel also has  tasks for process
> > migration with the name 'migration/cpu#'.
> > 
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> > ---
> >  migration/migration.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/migration/migration.c b/migration/migration.c
> > index f498ab8..6ebd606 100644
> > --- a/migration/migration.c
> > +++ b/migration/migration.c
> > @@ -1969,7 +1969,7 @@ void migrate_fd_connect(MigrationState *s)
> >      }
> >  
> >      migrate_compress_threads_create();
> > -    qemu_thread_create(&s->thread, "migration", migration_thread, s,
> > +    qemu_thread_create(&s->thread, "qemu_vm_migration", migration_thread,
> > s,
> >                         QEMU_THREAD_JOINABLE);
> 
> Are you sure that works?  For me it doesn't change the name.
> 
> There's a maximum length that I think is somewhere around 16 characters and
> that
> name is too long.
> 
> Changing it to "qemu_migration" seems to work.

Thanks for pointing out.
I will send a v2.

> 
> Dave
> 
> >      s->migration_thread_running = true;
> >  }
> > --
> > 2.7.4
> > 
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>