From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHYKI-000285-4u for qemu-devel@nongnu.org; Mon, 27 Jun 2016 11:19:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHYKH-0001Kn-44 for qemu-devel@nongnu.org; Mon, 27 Jun 2016 11:19:54 -0400 References: <1466500894-9710-1-git-send-email-kwolf@redhat.com> <1466500894-9710-17-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <791bd46a-b4d2-2bd8-618e-3a7a4a3d2d5a@redhat.com> Date: Mon, 27 Jun 2016 17:19:44 +0200 MIME-Version: 1.0 In-Reply-To: <1466500894-9710-17-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="imDIe9wjHASB1Ec7eDKxfuItDoBGAW1w4" Subject: Re: [Qemu-devel] [PATCH 16/17] block: Convert bdrv_prwv_co() to BdrvChild List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: stefanha@redhat.com, famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --imDIe9wjHASB1Ec7eDKxfuItDoBGAW1w4 From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: stefanha@redhat.com, famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org Message-ID: <791bd46a-b4d2-2bd8-618e-3a7a4a3d2d5a@redhat.com> Subject: Re: [PATCH 16/17] block: Convert bdrv_prwv_co() to BdrvChild References: <1466500894-9710-1-git-send-email-kwolf@redhat.com> <1466500894-9710-17-git-send-email-kwolf@redhat.com> In-Reply-To: <1466500894-9710-17-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 21.06.2016 11:21, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/io.c | 37 +++++++++++++++++++++---------------- > 1 file changed, 21 insertions(+), 16 deletions(-) >=20 > diff --git a/block/io.c b/block/io.c > index 641cd49..78529fc 100644 > --- a/block/io.c > +++ b/block/io.c [...] > @@ -2202,9 +2201,15 @@ void qemu_aio_unref(void *p) > /**************************************************************/ > /* Coroutine block device emulation */ > =20 > +typedef struct FlushCo { > + BlockDriverState *bs; > + int ret; > +} FlushCo; > + > + > static void coroutine_fn bdrv_flush_co_entry(void *opaque) > { > - RwCo *rwco =3D opaque; > + FlushCo *rwco =3D opaque; > =20 > rwco->ret =3D bdrv_co_flush(rwco->bs); > } > @@ -2288,7 +2293,7 @@ out: > int bdrv_flush(BlockDriverState *bs) > { > Coroutine *co; > - RwCo rwco =3D { > + FlushCo rwco =3D { > .bs =3D bs, > .ret =3D NOT_DONE, > }; >=20 Renaming the variable to something other than rwco would make sense, but I'll leave that up to you. Reviewed-by: Max Reitz --imDIe9wjHASB1Ec7eDKxfuItDoBGAW1w4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXcUQQEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrW8L B/4/4UKuh3iY5/froqu8w0kqstI/ovDrp//S/+vT7+SfiG9yNU6m/QjfXoiP04nz Kf8cw7oQXZ3ezYdsAD24okjX99zk+MjjZtt/2VcrJGTyrzibHKe9vDIlxmDWX05s y14oL3Mj3oGFLZzybMMPh8dSohY9Et1HM1z7yx7Xke9K2EHu2/FZSVj2cyOuP+Yg fqrqgXhTHImCAYVX0DUyjgo2SrnDd8VI06W2mtCRQbtdjmzUQWqnl3aXg3jhjKDr nlbUJoP7KziN2vp3dvgMyr7mUsoEHZrQuabgFohaaWf+v4F6538C9dounGyHSfI2 ahD+4UyzIP66xy8kLjr3mzk0 =MLF6 -----END PGP SIGNATURE----- --imDIe9wjHASB1Ec7eDKxfuItDoBGAW1w4--