From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: Nikolay Borisov <nborisov@suse.com>,
Juan Quintela <quintela@redhat.com>,
Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH] migration/ram: Refactor precopy ram loading code
Date: Tue, 25 Jul 2023 15:31:16 +0200 [thread overview]
Message-ID: <7921da3a-91ce-af1a-b74e-6b8791bdeffb@linaro.org> (raw)
In-Reply-To: <20230725132651.18635-1-farosas@suse.de>
On 25/7/23 15:26, Fabiano Rosas wrote:
> From: Nikolay Borisov <nborisov@suse.com>
>
> Extract the ramblock parsing code into a routine that operates on the
> sequence of headers from the stream and another the parses the
> individual ramblock. This makes ram_load_precopy() easier to
> comprehend.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> I'm extracting the parts from the fixed-ram migration series [1] that
> could already go in. This patch is one of them.
>
> 1- https://lore.kernel.org/r/20230330180336.2791-1-farosas@suse.de
> ---
> migration/ram.c | 141 +++++++++++++++++++++++++++---------------------
> 1 file changed, 79 insertions(+), 62 deletions(-)
I'd rather 1 patch extracting parse_ramblock() then another
one for parse_ramblocks(), anyhow:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-25 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 13:26 [PATCH] migration/ram: Refactor precopy ram loading code Fabiano Rosas
2023-07-25 13:31 ` Philippe Mathieu-Daudé [this message]
2023-07-26 17:58 ` Peter Xu
2023-08-22 12:10 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7921da3a-91ce-af1a-b74e-6b8791bdeffb@linaro.org \
--to=philmd@linaro.org \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=nborisov@suse.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).