From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8mEv-0003nU-Dx for qemu-devel@nongnu.org; Mon, 12 Aug 2013 03:08:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8mEu-0003op-BF for qemu-devel@nongnu.org; Mon, 12 Aug 2013 03:08:29 -0400 Received: from mail.avalus.com ([2001:41c8:10:1dd::10]:46735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8mEu-0003oh-5H for qemu-devel@nongnu.org; Mon, 12 Aug 2013 03:08:28 -0400 Date: Mon, 12 Aug 2013 08:08:12 +0100 From: Alex Bligh Message-ID: <792B6DE3FBC205EC07EF66B0@nimrod.local> In-Reply-To: <52088652.3010201@linux.vnet.ibm.com> References: <1375998147-24292-1-git-send-email-alex@alex.org.uk> <1375998147-24292-10-git-send-email-alex@alex.org.uk> <5204BE51.70006@redhat.com> <66F49369-34D8-4F02-87B7-946095072EBD@alex.org.uk> <5204FE33.1060306@redhat.com> <520503D2.1020006@redhat.com> <12227494-C6D2-467E-B7B3-6765F78EEB44@alex.org.uk> <52088652.3010201@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: Re: [Qemu-devel] [RFC] [PATCHv8 09/30] aio / timers: Add QEMUTimerListGroup and helper functions Reply-To: Alex Bligh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: Kevin Wolf , Anthony Liguori , Alex Bligh , liu ping fan , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini , MORITA Kazutaka , rth@twiddle.net --On 12 August 2013 14:53:06 +0800 Wenchao Xia wrote: >> 1. Wrap TimerListGroup into a separate struct, leave all the >> TimerListGroup functions in. This probably makes it easier if >> (for instance) we decided to get rid of AioContexts entirely >> and make them g_source subclasses (per Wenchao Xia). >> > I have a quick view of this series, but not very carefully since > it is quite long.:) I have replied with Paolo's comments on my > RFC thread. Personally I like g_source sub class, which make code > clear, but let's discuss first if the direction is right in that mail. Looks like Paolo is happy going with TimerListGroup for now. So I wrapped the array in a struct for v10. -- Alex Bligh