From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9uQM-0002TJ-5t for qemu-devel@nongnu.org; Mon, 06 Jun 2016 09:18:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9uQG-0003yo-Ju for qemu-devel@nongnu.org; Mon, 06 Jun 2016 09:18:34 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:53135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9uQG-0003yW-C1 for qemu-devel@nongnu.org; Mon, 06 Jun 2016 09:18:28 -0400 Date: Mon, 6 Jun 2016 09:18:27 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <793068667.3695930.1465219107472.JavaMail.zimbra@redhat.com> In-Reply-To: <1465194905.24775.180.camel@redhat.com> References: <1465076003-26291-1-git-send-email-marcandre.lureau@redhat.com> <1465076003-26291-12-git-send-email-marcandre.lureau@redhat.com> <1465194905.24775.180.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 11/14] console: add dpy_gl_scanout2() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: marcandre lureau , qemu-devel@nongnu.org Hi ----- Original Message ----- > Hi, > > > @@ -218,6 +218,11 @@ typedef struct DisplayChangeListenerOps { > > void (*dpy_gl_scanout)(DisplayChangeListener *dcl, > > uint32_t backing_id, bool backing_y_0_top, > > uint32_t x, uint32_t y, uint32_t w, uint32_t > > h); > > + void (*dpy_gl_scanout2)(DisplayChangeListener *dcl, > > + int fd, bool backing_y_0_top, > > + uint32_t x, uint32_t y, uint32_t w, uint32_t > > h, > > + uint32_t fd_w, uint32_t fd_h, uint32_t > > fd_stride, > > + int fd_fourcc); > > Interface looks sane. I'd like to see a more descriptive name than just > "2" though. Maybe "dpy_gl_scanout_dmabuf"? And while being at it > rename the other one to "dpy_gl_scanout_texture"? sounds good > > Also: please put the spice update into a separate patch. ok > > Adding gtk (or sdl2, or both) support would be nice, to see whenever the > interface works if qemu needs to import the dma-buf for display. As I explained in cover, it's not easily doable since gtk/sdl2 use glx, and can't import dmabuf (it needs egl). I could make it work with gtk/egl (but not gtkglarea, sigh, so many UIs and subtle issues)