From: "Denis V. Lunev" <den@virtuozzo.com>
To: Stefan Hajnoczi <stefanha@gmail.com>, "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PULL 00/22] implement discard operation for Parallels images
Date: Wed, 20 Sep 2023 22:38:07 +0200 [thread overview]
Message-ID: <7972e21f-f850-c11c-8e1c-a25ea2ce6a9b@virtuozzo.com> (raw)
In-Reply-To: <CAJSP0QWXi0pGy7NKq42u3-=3GPP6kFnz6TA7HaBs8ZBXjKLidg@mail.gmail.com>
On 9/20/23 19:55, Stefan Hajnoczi wrote:
> On Wed, 20 Sept 2023 at 05:22, Denis V. Lunev <den@openvz.org> wrote:
>> The following changes since commit 4907644841e3200aea6475c0f72d3d987e9f3d93:
>>
>> Merge tag 'mem-2023-09-19' of https://github.com/davidhildenbrand/qemu into staging (2023-09-19 13:22:19 -0400)
>>
>> are available in the Git repository at:
>>
>> https://src.openvz.org/scm/~den/qemu.git tags/pull-parallels-2023-09-20
> Hi Denis,
> Please take a look at the following CI failure. I have dropped this
> series for now.
>
> clang -m64 -mcx16 -Ilibblock.fa.p -I. -I.. -Iqapi -Itrace -Iui
> -Iui/shader -Iblock -I/usr/include/p11-kit-1 -I/usr/include/uuid
> -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
> -I/usr/include/sysprof-4 -flto -fcolor-diagnostics -Wall -Winvalid-pch
> -Werror -std=gnu11 -O2 -g -fstack-protector-strong
> -fsanitize=safe-stack -Wundef -Wwrite-strings -Wmissing-prototypes
> -Wstrict-prototypes -Wredundant-decls -Wold-style-definition
> -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self
> -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels
> -Wexpansion-to-defined -Wmissing-format-attribute
> -Wno-initializer-overrides -Wno-missing-include-dirs
> -Wno-shift-negative-value -Wno-string-plus-int
> -Wno-typedef-redefinition -Wno-tautological-type-limit-compare
> -Wno-psabi -Wno-gnu-variable-sized-type-not-at-end -Wthread-safety
> -isystem /builds/qemu-project/qemu/linux-headers -isystem
> linux-headers -iquote . -iquote /builds/qemu-project/qemu -iquote
> /builds/qemu-project/qemu/include -iquote
> /builds/qemu-project/qemu/host/include/x86_64 -iquote
> /builds/qemu-project/qemu/host/include/generic -iquote
> /builds/qemu-project/qemu/tcg/i386 -pthread -D_GNU_SOURCE
> -D_LARGEFILE_SOURCE -fno-strict-aliasing -fno-common -fwrapv
> -fsanitize=cfi-icall -fsanitize-cfi-icall-generalize-pointers
> -fno-sanitize-trap=cfi-icall -fPIE -D_FILE_OFFSET_BITS=64
> -D__USE_FILE_OFFSET64 -D__USE_LARGEFILE64 -DUSE_POSIX_ACLS=1 -MD -MQ
> libblock.fa.p/block_parallels.c.o -MF
> libblock.fa.p/block_parallels.c.o.d -o
> libblock.fa.p/block_parallels.c.o -c ../block/parallels.c
> ../block/parallels.c:210:21: error: calling function
> 'bdrv_co_getlength' requires holding mutex 'graph_lock'
> [-Werror,-Wthread-safety-analysis]
> payload_bytes = bdrv_co_getlength(bs->file->bs);
> ^
> ../block/parallels.c:572:15: error: calling function
> 'bdrv_co_pdiscard' requires holding mutex 'graph_lock'
> [-Werror,-Wthread-safety-analysis]
> ret = bdrv_co_pdiscard(bs->file, host_off, s->cluster_size);
> ^
> 2 errors generated.
>
> https://gitlab.com/qemu-project/qemu/-/jobs/5131277794
>
> Stefan
>
>
It seems that GCC and CLANG environments are different
nowadays. I have had a smell of that but have not have
a proof. Will try to understand.
Den
prev parent reply other threads:[~2023-09-20 20:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 9:20 [PULL 00/22] implement discard operation for Parallels images Denis V. Lunev
2023-09-20 9:20 ` [PULL 01/22] parallels: fix formatting in bdrv_parallels initialization Denis V. Lunev
2023-09-20 9:20 ` [PULL 02/22] parallels: mark driver as supporting CBT Denis V. Lunev
2023-09-20 9:20 ` [PULL 03/22] parallels: fix memory leak in parallels_open() Denis V. Lunev
2023-09-20 9:20 ` [PULL 04/22] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts Denis V. Lunev
2023-09-20 9:20 ` [PULL 05/22] parallels: return earler in fail_format branch in parallels_open() Denis V. Lunev
2023-09-20 9:20 ` [PULL 06/22] parallels: return earlier from parallels_open() function on error Denis V. Lunev
2023-09-20 9:20 ` [PULL 07/22] parallels: refactor path when we need to re-check image in parallels_open Denis V. Lunev
2023-09-20 9:20 ` [PULL 08/22] parallels: create mark_used() helper which sets bit in used bitmap Denis V. Lunev
2023-09-20 9:20 ` [PULL 09/22] tests: ensure that image validation will not cure the corruption Denis V. Lunev
2023-09-20 9:20 ` [PULL 10/22] parallels: fix broken parallels_check_data_off() Denis V. Lunev
2023-09-20 9:20 ` [PULL 11/22] parallels: add test which will validate data_off fixes through repair Denis V. Lunev
2023-09-20 9:20 ` [PULL 12/22] parallels: collect bitmap of used clusters at open Denis V. Lunev
2023-09-20 9:20 ` [PULL 13/22] tests: fix broken deduplication check in parallels format test Denis V. Lunev
2023-09-20 9:21 ` [PULL 14/22] tests: test self-cure of parallels image with duplicated clusters Denis V. Lunev
2023-09-20 9:21 ` [PULL 15/22] parallels: accept multiple clusters in mark_used() Denis V. Lunev
2023-09-20 9:21 ` [PULL 16/22] parallels: update used bitmap in allocate_cluster Denis V. Lunev
2023-09-20 9:21 ` [PULL 17/22] parallels: naive implementation of allocate_clusters with used bitmap Denis V. Lunev
2023-09-20 9:21 ` [PULL 18/22] parallels: improve readability of allocate_clusters Denis V. Lunev
2023-09-20 9:21 ` [PULL 19/22] parallels: naive implementation of parallels_co_pdiscard Denis V. Lunev
2023-09-20 9:21 ` [PULL 20/22] tests: extend test 131 to cover availability of the discard operation Denis V. Lunev
2023-09-20 9:21 ` [PULL 21/22] parallels: naive implementation of parallels_co_pwrite_zeroes Denis V. Lunev
2023-09-20 9:21 ` [PULL 22/22] tests: extend test 131 to cover availability of the write-zeroes Denis V. Lunev
2023-09-20 17:55 ` [PULL 00/22] implement discard operation for Parallels images Stefan Hajnoczi
2023-09-20 20:38 ` Denis V. Lunev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7972e21f-f850-c11c-8e1c-a25ea2ce6a9b@virtuozzo.com \
--to=den@virtuozzo.com \
--cc=den@openvz.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).