From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option
Date: Thu, 4 Jan 2018 13:50:57 +0100 [thread overview]
Message-ID: <797565f6-894a-1663-7375-afbcb1d1a70b@redhat.com> (raw)
In-Reply-To: <CAFEAcA_YUDYVUGaa5-ZUCQB6ErGySFtg_wO6=Ah=vyK7hAASPA@mail.gmail.com>
On 04.01.2018 13:49, Peter Maydell wrote:
> On 4 January 2018 at 12:44, Thomas Huth <thuth@redhat.com> wrote:
>> On 04.01.2018 13:33, Peter Maydell wrote:
>>> The diffstat is nice, but can we retain the "please use
>>> $NEWOPTION instead of $OLDOPTION" message for a bit?
>>> I'm pretty sure there will be users out there who've
>>> been happily ignoring deprecation notices, and I think
>>> we'll reduce the amount of support traffic if they
>>> get a new QEMU with a specific error message telling them
>>> what they need to fix, rather than one which just prints
>>> a generic "unknown option" message.
>>
>> Sounds like a good idea at the first glance ... but at a second thought:
>> Don't we confuse the management layers like libvirt this way, which
>> might probe for the availability of this option by executing QEMU with
>> this parameter?
>
> If they do (which I'd hope they don't) then QEMU will
> exit with a failure status code, which they ought to
> identify as "not supported".
OK, makes sense. I'll cook a v2 of the patch accordingly...
Thomas
next prev parent reply other threads:[~2018-01-04 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 12:27 [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option Thomas Huth
2018-01-04 12:33 ` Peter Maydell
2018-01-04 12:44 ` Thomas Huth
2018-01-04 12:49 ` Peter Maydell
2018-01-04 12:50 ` Thomas Huth [this message]
2018-01-04 17:38 ` Eric Blake
2018-01-04 13:26 ` Samuel Thibault
2018-01-04 14:22 ` Thomas Huth
2018-01-04 14:23 ` Samuel Thibault
2018-01-04 15:01 ` Thomas Huth
2018-01-04 15:22 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=797565f6-894a-1663-7375-afbcb1d1a70b@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).