From: Julia Suvorova <jusual@mail.ru>
To: Alistair Francis <alistair23@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting
Date: Wed, 16 Jan 2019 22:05:58 +0300 [thread overview]
Message-ID: <797be79d-7ffc-222a-6acd-b01ff7269a63@mail.ru> (raw)
In-Reply-To: <CAKmqyKOyfP=ZT-diiFFfAieYKt98DPSxf0HyVdwYE4g+jv5w0w@mail.gmail.com>
On 16.01.2019 0:51, Alistair Francis wrote:
> On Tue, Jan 15, 2019 at 7:04 AM Julia Suvorova via Qemu-devel
> <qemu-devel@nongnu.org> wrote:
>>
>> If the memory is set using a file, and PC is specified on the command
>> line, it will be overwritten with the value 'entry'. This is not only
>> illogical, but also incorrect, because the load_ * functions do not take
>> into account the specifics of the ARM-M PC.
>
> How does this come up?
> I see that the value of entry will force overwrite the PC addr, but
> doesn't force_raw fix that? Is there a common use case of loading an
> ELF/uimage but having to manually specify a start address?
generic_loader_reset() is called after arm_cpu_reset() and damages PC
(it is wrong to call arm_cpu_set_pc() with entry to set ARM PC reset
value). Therefore, I tried to configure PC manually and ran into this
problem.
By the way, I do not know the right way to fix the original issue. Try
to replace generic_loader_reset() with the device reset function or
change the reset order or transfer PC reset value setting to a separate
function and associate it with cpu. What do you think about it?
Best regards, Julia Suvorova.
next prev parent reply other threads:[~2019-01-16 19:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 14:36 [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting Julia Suvorova
2019-01-15 21:51 ` Alistair Francis
2019-01-16 19:05 ` Julia Suvorova [this message]
2019-01-17 10:13 ` Stefan Hajnoczi
2019-01-17 10:58 ` Julia Suvorova
2019-01-17 19:27 ` Peter Maydell
2019-01-17 19:55 ` Peter Maydell
2019-01-21 17:24 ` Peter Maydell
2019-01-22 13:59 ` Julia Suvorova
2019-01-22 14:58 ` Peter Maydell
2019-01-21 3:11 ` no-reply
2019-01-21 3:22 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=797be79d-7ffc-222a-6acd-b01ff7269a63@mail.ru \
--to=jusual@mail.ru \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).