From: Paolo Bonzini <pbonzini@redhat.com>
To: luoyonggang@gmail.com, qemu-level <qemu-devel@nongnu.org>
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py
Date: Wed, 7 Oct 2020 18:43:20 +0200 [thread overview]
Message-ID: <798fb17d-fcf5-3234-1e17-37b3c0a18b8e@redhat.com> (raw)
In-Reply-To: <CAE2XoE9sf0p5QuG=dSqbOvmGvbzDaEBN8qSG1ejM=RH+D+zq1g@mail.gmail.com>
On 07/10/20 18:23, 罗勇刚(Yonggang Luo) wrote:
>> + if not pkgversion and os.path.exists('.git'):
>> + # The quote of v* should preserve, otherwise git command
> would fail
>> + pc = subprocess.run(['git', 'describe', '--match', "'v*'",
> '--dirty', '--always'],
>> + stdout=subprocess.PIPE,
> stderr=subprocess.DEVNULL, encoding='utf8')
It's a total mess.
On Linux, if you use 'v*' git is invoked with an argument that looks
like 'v*', that is as if you used \'v\*\' on bash.
On Windows, wildcard expansion is done by the program so you need to
pass a quoted value to stop the wildcard expansion.
I have no idea how to fix it. Probably it can be made to work using a
string argument and "shell=True", but at this point it makes more sense
to keep the shell script version.
Paolo
next prev parent reply other threads:[~2020-10-07 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 16:21 [PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py Yonggang Luo
2020-10-07 16:23 ` 罗勇刚(Yonggang Luo)
2020-10-07 16:43 ` Paolo Bonzini [this message]
2020-10-07 19:14 ` 罗勇刚(Yonggang Luo)
2020-10-07 19:18 ` Peter Maydell
2020-10-07 19:50 ` Paolo Bonzini
2020-10-07 16:48 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=798fb17d-fcf5-3234-1e17-37b3c0a18b8e@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=luoyonggang@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).