From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9n59-0004B5-NI for qemu-devel@nongnu.org; Mon, 06 Jun 2016 01:28:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9n56-0002g8-Hw for qemu-devel@nongnu.org; Mon, 06 Jun 2016 01:28:11 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:15643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9n56-0002fv-9b for qemu-devel@nongnu.org; Mon, 06 Jun 2016 01:28:08 -0400 References: <1464119897-10844-1-git-send-email-kwankhede@nvidia.com> <1464119897-10844-2-git-send-email-kwankhede@nvidia.com> <20160603165746.3df39542@oc7835276234> From: Kirti Wankhede Message-ID: <799479b0-44d5-061f-185a-43df0dba2fb3@nvidia.com> Date: Mon, 6 Jun 2016 10:57:49 +0530 MIME-Version: 1.0 In-Reply-To: <20160603165746.3df39542@oc7835276234> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Jia Cc: alex.williamson@redhat.com, pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, shuai.ruan@intel.com, jike.song@intel.com, zhiyuan.lv@intel.com On 6/3/2016 2:27 PM, Dong Jia wrote: > On Wed, 25 May 2016 01:28:15 +0530 > Kirti Wankhede wrote: > > > ...snip... > >> +struct phy_device_ops { >> + struct module *owner; >> + const struct attribute_group **dev_attr_groups; >> + const struct attribute_group **mdev_attr_groups; >> + >> + int (*supported_config)(struct device *dev, char *config); >> + int (*create)(struct device *dev, uuid_le uuid, >> + uint32_t instance, char *mdev_params); >> + int (*destroy)(struct device *dev, uuid_le uuid, >> + uint32_t instance); >> + int (*start)(uuid_le uuid); >> + int (*shutdown)(uuid_le uuid); >> + ssize_t (*read)(struct mdev_device *vdev, char *buf, size_t count, >> + enum mdev_emul_space address_space, loff_t pos); >> + ssize_t (*write)(struct mdev_device *vdev, char *buf, size_t count, >> + enum mdev_emul_space address_space, loff_t pos); >> + int (*set_irqs)(struct mdev_device *vdev, uint32_t flags, >> + unsigned int index, unsigned int start, >> + unsigned int count, void *data); >> + int (*get_region_info)(struct mdev_device *vdev, int region_index, >> + struct pci_region_info *region_info); >> + int (*validate_map_request)(struct mdev_device *vdev, >> + unsigned long virtaddr, >> + unsigned long *pfn, unsigned long *size, >> + pgprot_t *prot); >> +}; > > Dear Kirti: > > When I rebased my vfio-ccw patches on this series, I found I need an > extra 'ioctl' callback in phy_device_ops. > Thanks for taking closer look. As per my knowledge ccw is not PCI device, right? Correct me if I'm wrong. I'm curious to know. Are you planning to write a driver (vfio-mccw) for mediated ccw device? Thanks, Kirti > The ccw physical device only supports one ccw mediated device. And I > have two new ioctl commands for the ccw mediated device. One is > to hot-reset the resource in the physical device that allocated for > the mediated device, the other is to do an I/O instruction translation > and perform an I/O operation on the physical device. I found the > existing callbacks could not meet my requirements. > > Something like the following would be fine for my case: > int (*ioctl)(struct mdev_device *vdev, > unsigned int cmd, > unsigned long arg); > > What do you think about this? > > -------- > Dong Jia >