From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E26C433E2 for ; Fri, 11 Sep 2020 23:36:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BAB721D91 for ; Fri, 11 Sep 2020 23:36:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Nobw/yhL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BAB721D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGsaS-00027o-FZ for qemu-devel@archiver.kernel.org; Fri, 11 Sep 2020 19:36:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGsZn-0001Oq-Fm for qemu-devel@nongnu.org; Fri, 11 Sep 2020 19:35:31 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:46814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGsZk-00065W-Sd for qemu-devel@nongnu.org; Fri, 11 Sep 2020 19:35:31 -0400 Received: by mail-pl1-x641.google.com with SMTP id d16so1594151pll.13 for ; Fri, 11 Sep 2020 16:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gy9ew762Kz8uAcIp89Zw7N6msNMi6asxKV4Mu1sd6/4=; b=Nobw/yhLj2jWrtf+pxiOb5rRm/xgka26iOmvDiSC3KT5QRYuPXqZu7yqEAPq3gbw00 0sRD9sYmKOOohpNu5/wlZeDkWfanHzRyHhVKmYt0xkili02zcukPx4qd6ZSPRwC58DLz lWdmUbdOFOwMpSpNxSncpozdbv8IY3SWW7XLLeJXQthwvXSsOQCA8dtYAuzRhIpDqKMG OkMRCiL+csjgBw/Nvd59ywjqKY+agDeVnprtpuDUSFAW/0W1Mhwx8P1SuwH3qiUN6poS GYbYV6TXcLsKeBtc5c4h5QTC493aJfrm/oBIjr/l6rvbGFlwAYShDHMvUwxaDV1OOX+C Upzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gy9ew762Kz8uAcIp89Zw7N6msNMi6asxKV4Mu1sd6/4=; b=kTJf0RMXRK2o+8CsckgJBxUc+RvUN4ZufZ5VVN29FRscP250zWSMWki+daeqq5vMsz nDiO2e4FH5Ky2Ky8C0eMKkwHv7c2Sb75FSVjcD1A/QnrBXu0Gk/Gmad7nW8grOpIDT+j aRetndxIwV/Y/A1RlNO/uUEaKMg9InUCLwNCK4tEjQtRI/nKj2erRetsXaZocQwW7OQQ pN3Ep2mFIjbJLq7cAuG5BtmZNi9WuiTAXu0MspXQbVEMsMp9jEgmyR9njJRQfcQmz33h FgP8jqKVh/SXz/glElsjyJTCqOxzDYiw1QNSqur52uWCoUv8UhQpVnYLr40Hw8Fc97e0 HONA== X-Gm-Message-State: AOAM533GW886/xxww2vBGtmeZ17MKsIpFxsk/3wAz9WdJRasDPsrZqL6 J2YNxukxoDaT5OvU/6bfVeFmxw== X-Google-Smtp-Source: ABdhPJw0E+YM8CiAuUzIr6bZ8d6WRqm7v8kuzmMaXnsqh8Or8HfKM/NcP+9SXRzX0SuiUDV0mWhX6A== X-Received: by 2002:a17:902:a40e:: with SMTP id p14mr4158367plq.4.1599867327150; Fri, 11 Sep 2020 16:35:27 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id 63sm3298449pfw.42.2020.09.11.16.35.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2020 16:35:26 -0700 (PDT) Subject: Re: [PATCH v2 0/2] hw: Replace some impossible checks by assertions To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200910072325.439344-1-f4bug@amsat.org> From: Richard Henderson Message-ID: <7996e747-9163-649c-9477-3d437bfecf60@linaro.org> Date: Fri, 11 Sep 2020 16:35:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200910072325.439344-1-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x641.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.469, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/10/20 12:23 AM, Philippe Mathieu-Daudé wrote: > Trivial patches removing unreachable code. > > Since v1: > - dropped patches queued > - replace dead code by assert (Peter) > - use PCI_NUM_PINS definition (Cédric) > > Philippe Mathieu-Daudé (2): > hw/gpio/max7310: Remove impossible check > hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition > > hw/gpio/max7310.c | 5 +---- > hw/ppc/ppc4xx_pci.c | 2 +- > 2 files changed, 2 insertions(+), 5 deletions(-) > Reviewed-by: Richard Henderson r~