Re: [PATCH v10 6/9] gfxstream + rutabaga: add initial support for gfxstream

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

Hi,

On 22/8/23 02:00, Gurchetan Singh wrote:
> This adds initial support for gfxstream and cross-domain.  Both
> features rely on virtio-gpu blob resources and context types, which
> are also implemented in this patch.
[...]

>   hw/display/virtio-gpu-pci-rutabaga.c |   48 ++
>   hw/display/virtio-gpu-rutabaga.c     | 1119 ++++++++++++++++++++++++++
>   hw/display/virtio-vga-rutabaga.c     |   51 ++
>   3 files changed, 1218 insertions(+)
>   create mode 100644 hw/display/virtio-gpu-pci-rutabaga.c
>   create mode 100644 hw/display/virtio-gpu-rutabaga.c
>   create mode 100644 hw/display/virtio-vga-rutabaga.c
> 
> diff --git a/hw/display/virtio-gpu-pci-rutabaga.c b/hw/display/virtio-gpu-pci-rutabaga.c
> new file mode 100644
> index 0000000000..c71173d8ca
> --- /dev/null
> +++ b/hw/display/virtio-gpu-pci-rutabaga.c
> @@ -0,0 +1,48 @@
> +// SPDX-License-Identifier: GPL-2.0

QEMU expects contributions to be GPL-2.0-or-later, see ./LICENSE:

    As of July 2013, contributions under version 2 of the GNU General
    Public License (and no later version) are only accepted for the
    following files or directories: bsd-user/, linux-user/, hw/vfio/,
    hw/xen/xen_pt*.

Also, per 
https://qemu-project.gitlab.io/qemu/devel/style.html#comment-style:

   We use traditional C-style /* */ comments and avoid // comments.

(You can use ./scripts/checkpatch.pl to check your patches style).

> diff --git a/hw/display/virtio-gpu-rutabaga.c b/hw/display/virtio-gpu-rutabaga.c
> new file mode 100644
> index 0000000000..bcb3885f1f
> --- /dev/null
> +++ b/hw/display/virtio-gpu-rutabaga.c
> @@ -0,0 +1,1119 @@
> +// SPDX-License-Identifier: GPL-2.0


> diff --git a/hw/display/virtio-vga-rutabaga.c b/hw/display/virtio-vga-rutabaga.c
> new file mode 100644
> index 0000000000..2b2ffed8a6
> --- /dev/null
> +++ b/hw/display/virtio-vga-rutabaga.c
> @@ -0,0 +1,51 @@
> +// SPDX-License-Identifier: GPL-2.0