From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-trivial@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
"Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 2/3] io/task: Move 'qom/object.h' header to source
Date: Mon, 4 May 2020 10:42:58 -0700 [thread overview]
Message-ID: <799fe603-906c-c00b-07ce-0e7619c444f5@linaro.org> (raw)
In-Reply-To: <20200504084615.27642-3-f4bug@amsat.org>
On 5/4/20 1:46 AM, Philippe Mathieu-Daudé wrote:
> We need "qom/object.h" to call object_ref()/object_unref().
This description doesn't seem to match
> +++ b/include/io/task.h
> @@ -21,8 +21,6 @@
> #ifndef QIO_TASK_H
> #define QIO_TASK_H
>
> -#include "qom/object.h"
> -
> typedef struct QIOTask QIOTask;
>
> typedef void (*QIOTaskFunc)(QIOTask *task,
> diff --git a/io/task.c b/io/task.c
> index 1ae7b86488..53c0bed686 100644
> --- a/io/task.c
> +++ b/io/task.c
> @@ -22,6 +22,7 @@
> #include "io/task.h"
> #include "qapi/error.h"
> #include "qemu/thread.h"
> +#include "qom/object.h"
the change. Since io/task.c includes io/tash.h, what are you actually doing?
r~
next prev parent reply other threads:[~2020-05-04 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 8:46 [PATCH 0/3] qom: Few trivial patches Philippe Mathieu-Daudé
2020-05-04 8:46 ` [PATCH 1/3] qom/object: Move Object typedef to 'qemu/typedefs.h' Philippe Mathieu-Daudé
2020-05-04 17:40 ` Richard Henderson
2020-05-04 8:46 ` [PATCH 2/3] io/task: Move 'qom/object.h' header to source Philippe Mathieu-Daudé
2020-05-04 17:42 ` Richard Henderson [this message]
2020-05-04 19:43 ` Philippe Mathieu-Daudé
2020-05-04 8:46 ` [PATCH 3/3] qom/object: Make reparenting error more verbose Philippe Mathieu-Daudé
2020-05-04 11:30 ` [PATCH 0/3] qom: Few trivial patches no-reply
2020-05-04 11:36 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=799fe603-906c-c00b-07ce-0e7619c444f5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).