From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D61C47257 for ; Mon, 4 May 2020 17:45:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54AAA20721 for ; Mon, 4 May 2020 17:45:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LrTMMW2E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54AAA20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVf9b-0003gC-H5 for qemu-devel@archiver.kernel.org; Mon, 04 May 2020 13:45:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVf7P-0008D7-LH for qemu-devel@nongnu.org; Mon, 04 May 2020 13:43:03 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:40270) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVf7O-0007bp-LY for qemu-devel@nongnu.org; Mon, 04 May 2020 13:43:03 -0400 Received: by mail-pg1-x543.google.com with SMTP id j21so93665pgb.7 for ; Mon, 04 May 2020 10:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2SzaOyDPCGENpZgk3z0k+7YxceN/laQe387Ybrd9snY=; b=LrTMMW2E8fTShG3kD6zyyL4vmEI27hKKc0lqlhSd5T0+wP8GEBgE/8CmHBoHXvJtMb W0Z21BZbe24AnDm8aqWrvsTtSxhzru+LxvG478uc+oqbSVV9nY5+LNaW6HB4AX9ew19f EZ0IFDrPLdf3tRGasiHUvRKcez9w1MFzLO9wvMvZY5I8Ww846UyEA5t9MipDFIT8Mgmi +yAmqNT97I2/QKMh4zhUs4LBK4JVUk/cliqvRR3YN/zneXcfvTRXmLO3L9N8YGTs3MQq NYmZHSFglK0DFBHP9EjlmoqNkKB9Hi1kKzN/nNMZ6QHyXABY3eoF4xQH/1azSCMeMyt/ rm5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2SzaOyDPCGENpZgk3z0k+7YxceN/laQe387Ybrd9snY=; b=LROuRJwhs6FqotKTQvuYm/3rxIAdyWC1fhx9C6Zx3nZZL1Ehp3vv4SVcMrbQlRmjRt 9xzzZROMhLrc4hhWuhMJSRsednh/PgkUo8DeCxqS5fH3euP4HPFCc2bB/qYl0IT0r4SD xe8PCqP/DqN6vAZ7jWWXEhX+XXZKiMoPHExiOYE9+aJ93uObx9it9wo3OqPcGdeSdmYf US1hH/M6n09VxnfH/kmz2WuwI6Cw5IMqjnbLju4eH4UC97SZpXu6nZx03mRYeUotI4gA 4O09MibBhJEQSst5fHqSPhmJjve+DqUWaStRGPzlUKGzOzwcsycxsSSsHkwI3GrflA/S G+Nw== X-Gm-Message-State: AGi0PubCgNOmk4k8VDrC2QSGVjsujQq0piwvLY/ziYx0uskpJDpejzPI r/6WcVCpOapl8sqi6Dh+OzTFRA== X-Google-Smtp-Source: APiQypIWgaLX+awCXvsVRdewO8jmEiF9h4iuEuF8Xj9WFVE//tG7OTutaBIB3VyuU1hc5vM40x1aqw== X-Received: by 2002:a65:5b84:: with SMTP id i4mr70253pgr.263.1588614181180; Mon, 04 May 2020 10:43:01 -0700 (PDT) Received: from [192.168.1.11] (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id e5sm9366592pfd.64.2020.05.04.10.43.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2020 10:43:00 -0700 (PDT) Subject: Re: [PATCH 2/3] io/task: Move 'qom/object.h' header to source To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200504084615.27642-1-f4bug@amsat.org> <20200504084615.27642-3-f4bug@amsat.org> From: Richard Henderson Message-ID: <799fe603-906c-c00b-07ce-0e7619c444f5@linaro.org> Date: Mon, 4 May 2020 10:42:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200504084615.27642-3-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Markus Armbruster , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/4/20 1:46 AM, Philippe Mathieu-Daudé wrote: > We need "qom/object.h" to call object_ref()/object_unref(). This description doesn't seem to match > +++ b/include/io/task.h > @@ -21,8 +21,6 @@ > #ifndef QIO_TASK_H > #define QIO_TASK_H > > -#include "qom/object.h" > - > typedef struct QIOTask QIOTask; > > typedef void (*QIOTaskFunc)(QIOTask *task, > diff --git a/io/task.c b/io/task.c > index 1ae7b86488..53c0bed686 100644 > --- a/io/task.c > +++ b/io/task.c > @@ -22,6 +22,7 @@ > #include "io/task.h" > #include "qapi/error.h" > #include "qemu/thread.h" > +#include "qom/object.h" the change. Since io/task.c includes io/tash.h, what are you actually doing? r~