From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L4MJc-0000dL-HR
	for qemu-devel@nongnu.org; Sun, 23 Nov 2008 16:16:24 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L4MJb-0000d5-Nh
	for qemu-devel@nongnu.org; Sun, 23 Nov 2008 16:16:24 -0500
Received: from [199.232.76.173] (port=60988 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L4MJb-0000d2-J9
	for qemu-devel@nongnu.org; Sun, 23 Nov 2008 16:16:23 -0500
Received: from mail.gmx.net ([213.165.64.20]:55836)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1L4MJb-0000S5-BT
	for qemu-devel@nongnu.org; Sun, 23 Nov 2008 16:16:23 -0500
Message-ID: <79AE59D4E6D44984ADAF3F265B234562@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <20081116093345.23209.79952.stgit@dhcp-1-237.local>
	<20081116093355.23209.96231.stgit@dhcp-1-237.local>
	<6BBD568AF57A42CE81244D009F97923C@FSCPC>
	<20081118074628.GC11066@redhat.com>
	<20081118082746.GD11066@redhat.com>
In-Reply-To: <20081118082746.GD11066@redhat.com>
Date: Sun, 23 Nov 2008 22:15:36 +0100
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Bochs-developers] [PATCH v4 2/5] Preserve memory
	contentduringSMM init.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org

Gleb Natapov wrote:
> On Tue, Nov 18, 2008 at 09:46:28AM +0200, Gleb Natapov wrote:
>> > SMBASE is not relocated. If i don't mistake smm_init() should be run on S3
>> > resume and we would need something like
>> >
>> > pci_for_each_device(find_piix4pm)
>> > if (piix4pm_pcidev)
>> >    smm_init();
>> >
>> > in the resume path in rombios32.c.
>> >
>> Yes, you are right. I'll add it.
>> 
> What about this? (fixed version of 1/5 patch)

Looks good.
Do you intend to implement piix4_pm_reset() for qemu so register DEVACTB
is reset on qemu_system_reset_request()?

- Sebastian