From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8t74-0000hk-B4 for qemu-devel@nongnu.org; Thu, 11 May 2017 14:46:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8t6z-0004ZA-Hd for qemu-devel@nongnu.org; Thu, 11 May 2017 14:46:58 -0400 References: <20170504105444.8940-1-daniel.kucera@gmail.com> <20170508203556.GA22634@stefanha-x1.localdomain> <20170509165254.GA26793@stefanha-x1.localdomain> <20170510150016.GB19962@stefanha-x1.localdomain> <26a943da-3487-8d39-85fd-6e176af054e0@openvz.org> <20170511183549.GA20777@stefanha-x1.localdomain> <8e366dc1-6c51-5d97-33dd-7390bd762fe5@redhat.com> From: "Denis V. Lunev" Message-ID: <79b77d1d-8ecb-cca2-ee0f-47d1d4b10653@openvz.org> Date: Thu, 11 May 2017 20:46:43 +0200 MIME-Version: 1.0 In-Reply-To: <8e366dc1-6c51-5d97-33dd-7390bd762fe5@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] mirror: add sync mode incremental to drive-mirror and blockdev-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , Stefan Hajnoczi Cc: =?UTF-8?Q?Daniel_Ku=c4=8dera?= , Kevin Wolf , "open list:Block Jobs" , Markus Armbruster , Jeff Cody , qemu-devel@nongnu.org, Max Reitz , Vladimir Sementsov-Ogievskiy On 05/11/2017 08:43 PM, John Snow wrote: > > On 05/11/2017 02:35 PM, Stefan Hajnoczi wrote: >> Daniel's proposed patch isn't large or invasive. The QMP interface is >> consistent with the backup block job's sync=bitmap mode, it's a logical >> extension. >> >> If the concerns about the bitmap lifecycle are addressed and a test case >> is included then I don't see anything preventing this patch from being >> merged. >> > I agree. > > Daniel, I'm preoccupied with some other tasks at the moment, but I will > look over your patch again with an eye for how the bitmap data is > handled on failure cases. Once we agree on a design, we'll need some > basic tests (a success case, and one for each type of unique failure > path) and then we're good to go. > > --js yes, no problem from my side too, except the point raised by John about deletion of the bitmap during mirror. Den