qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, "Riku Voipio" <riku.voipio@iki.fi>,
	"Guido Günther" <agx@sigxcpu.org>
Subject: Re: [Qemu-devel] [PATCH v3 04/13] linux-user/strace: Add print_timezone()
Date: Mon, 2 Jul 2018 20:19:57 +0200	[thread overview]
Message-ID: <79b98fc1-922e-3517-bd3e-dee4c4ae1de2@vivier.eu> (raw)
In-Reply-To: <20180702175030.18621-5-f4bug@amsat.org>

Le 02/07/2018 à 19:50, Philippe Mathieu-Daudé a écrit :
> Suggested-by: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  linux-user/strace.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 311e63ef75..49bdee6d83 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -63,6 +63,7 @@ UNUSED static void print_string(abi_long, int);
>  UNUSED static void print_buf(abi_long addr, abi_long len, int last);
>  UNUSED static void print_raw_param(const char *, abi_long, int);
>  UNUSED static void print_timeval(abi_ulong, int);
> +UNUSED static void print_timezone(abi_ulong, int);
>  UNUSED static void print_number(abi_long, int);
>  UNUSED static void print_signal(abi_ulong, int);
>  UNUSED static void print_sockaddr(abi_ulong addr, abi_long addrlen);
> @@ -1184,6 +1185,26 @@ print_timeval(abi_ulong tv_addr, int last)
>          gemu_log("NULL%s", get_comma(last));
>  }
>  
> +static void
> +print_timezone(abi_ulong tz_addr, int last)
> +{
> +    if (tz_addr) {
> +        struct target_timezone *tz;
> +
> +        tz = lock_user(VERIFY_READ, tz_addr, sizeof(*tz), 1);
> +        if (!tz) {
> +            print_pointer(tz, last);

print_pointer(tz_addr, last);

Thanks,
Laurent

  parent reply	other threads:[~2018-07-02 18:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 17:50 [Qemu-devel] [PATCH v3 00/13] linux-user: strace improvements Philippe Mathieu-Daudé
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 01/13] linux-user/syscall: Verify recvfrom(addr) is user-writable Philippe Mathieu-Daudé
2018-07-03 14:55   ` Laurent Vivier
2018-07-03 15:39     ` Philippe Mathieu-Daudé
2018-07-03 16:38       ` Laurent Vivier
2018-07-03 21:05         ` Philippe Mathieu-Daudé
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 02/13] linux-user/strace: Improve capget()/capset() output Philippe Mathieu-Daudé
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 05/13] linux-user/strace: Improve settimeofday() Philippe Mathieu-Daudé
2018-07-02 18:20   ` Laurent Vivier
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 06/13] linux-user/strace: Dump AF_NETLINK sockaddr content Philippe Mathieu-Daudé
2018-07-02 19:05   ` Laurent Vivier
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 07/13] linux-user/strace: Improve recvmsg() output Philippe Mathieu-Daudé
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 10/13] linux-user/strace: Let print_sockaddr() have a 'last' argument Philippe Mathieu-Daudé
2018-07-02 18:40   ` Laurent Vivier
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 11/13] linux-user/strace: Add print_sockaddr_ptr() to handle plain/pointer addrlen Philippe Mathieu-Daudé
2018-07-02 18:52   ` Laurent Vivier
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 12/13] linux-user/strace: Improve getsockname() output Philippe Mathieu-Daudé
2018-07-02 18:46   ` Laurent Vivier
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 13/13] linux-user/strace: Improve recvfrom() output Philippe Mathieu-Daudé
2018-07-02 18:44   ` Laurent Vivier
     [not found] ` <20180702175030.18621-4-f4bug@amsat.org>
2018-07-02 18:18   ` [Qemu-devel] [PATCH v3 03/13] linux-user/strace: Display invalid pointer in print_timeval() Laurent Vivier
2018-07-02 18:26     ` Philippe Mathieu-Daudé
     [not found] ` <20180702175030.18621-5-f4bug@amsat.org>
2018-07-02 18:19   ` Laurent Vivier [this message]
     [not found] ` <20180702175030.18621-9-f4bug@amsat.org>
2018-07-02 18:30   ` [Qemu-devel] [PATCH v3 08/13] linux-user/strace: Improve bind() output Laurent Vivier
     [not found] ` <20180702175030.18621-10-f4bug@amsat.org>
2018-07-02 18:36   ` [Qemu-devel] [PATCH v3 09/13] linux-user/strace: improve sendto() output Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79b98fc1-922e-3517-bd3e-dee4c4ae1de2@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=agx@sigxcpu.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).